lib: converted element to lowercase in tty.js#26121
Closed
abshek wants to merge 1 commit intonodejs:masterfrom
Closed
lib: converted element to lowercase in tty.js#26121abshek wants to merge 1 commit intonodejs:masterfrom
abshek wants to merge 1 commit intonodejs:masterfrom
Conversation
Converted the first element "Eterm" in TERM_ENVS array to "eterm" Fixes: nodejs#26077
cjihrig
approved these changes
Feb 15, 2019
richardlau
approved these changes
Feb 15, 2019
antsmartian
approved these changes
Feb 15, 2019
starkwang
approved these changes
Feb 15, 2019
hiroppy
approved these changes
Feb 15, 2019
lpinca
approved these changes
Feb 15, 2019
jasnell
approved these changes
Feb 15, 2019
ChALkeR
approved these changes
Feb 16, 2019
JungMinu
approved these changes
Feb 16, 2019
Member
addaleax
added
the
author ready
Contributor
|
Re-run of failing node-test-commit-aix (✔️) |
Contributor
|
Landed in 17820ec. |
danbev
pushed a commit
that referenced
this pull request
Feb 19, 2019
Converted the first element "Eterm" in TERM_ENVS array to "eterm" PR-URL: #26121 Fixes: #26077 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Member
|
(This should probably have landed with a |
addaleax
pushed a commit
that referenced
this pull request
Feb 19, 2019
Converted the first element "Eterm" in TERM_ENVS array to "eterm" PR-URL: #26121 Fixes: #26077 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Converted the first element "Eterm" in TERM_ENVS array to "eterm" PR-URL: #26121 Fixes: #26077 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converted the first element "Eterm" in TERM_ENVS array to "eterm"
Fixes: #26077
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes