test: add arg to narrow http benchmark test#26101
Conversation
|
Special CI job: https://ci.nodejs.org/job/node-test-commit-custom-suites/872/ |
refack
added
benchmark
|
An alternative could be to rename the new arg to |
|
Please 👍 to fast-track since ATM the daily master job is failing |
There was a problem hiding this comment.
Can you relocate it higher in the list to keep the list in alphabetical order?
There was a problem hiding this comment.
Can you relocate it higher in the list to keep the list in alphabetical order?
Argh, never mind, it's already not alphabetical, just mostly alphabetical. Anyway, LGTM, but nit: Would prefer to alphabetize the list.
(Also, agree that n is probably better. The headers aren't duplicates. They're similarly-named.)
PR-URL: nodejs#26101 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
refack
force-pushed
the
only-one-bench-http-incoming_headers
branch
from
182ec22 to
fe58bef
Compare
|
Fast-tracked with 3 upvotes @Trott I'll make a follow up clean PR. |
|
Refactoring PR #26119 |
PR-URL: #26101 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs#26119 Refs: nodejs#26101 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #26101 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
6 participants
Recent changes (da0dc51) added a new benchmark (
benchmark/http/incoming_headers.js) which takes a new arg (headerDuplicates).This PR passes a value for that arg so that during the sanity test this benchmark will run only once.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes