test,worker: add more tests for worker.ref()/.unref()#26083
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
test,worker: add more tests for worker.ref()/.unref()#26083addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
richardlau
approved these changes
Feb 13, 2019
Member
Author
Member
Author
|
Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20770/ (:heavy_check_mark:) |
jasnell
approved these changes
Feb 14, 2019
addaleax
added
the
author ready
cjihrig
approved these changes
Feb 15, 2019
Member
Author
|
Landed in 6a2dde5 |
addaleax
added a commit
that referenced
this pull request
Feb 15, 2019
PR-URL: #26083 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
Author
|
Hmpf … looks like one of the tests here might be flaky? :/ I can’t reproduce locally so far … I’ll keep trying for now. If this turns out to be a frequent problem we should remove the test or mark it as flaky, though. |
addaleax
added a commit
that referenced
this pull request
Feb 16, 2019
PR-URL: #26083 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #26083 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes