tools: make trailing commas consistent in .eslintrc#25739
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
tools: make trailing commas consistent in .eslintrc#25739Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
.eslintrc has lots of trailing commas and lots of places where there aren't trailing commas. Use trailing commas throughout the files for consistency.
targos
approved these changes
Jan 27, 2019
vsemozhetbyt
approved these changes
Jan 27, 2019
Trott
added
the
author ready
lpinca
approved these changes
Jan 27, 2019
devsnek
approved these changes
Jan 27, 2019
Member
devsnek
left a comment
devsnek
left a comment
There was a problem hiding this comment.
if only we could do this to the whole codebase 😢
Member
Author
|
Member
|
Landed in 1a37fd6 |
targos
pushed a commit
that referenced
this pull request
Jan 29, 2019
.eslintrc has lots of trailing commas and lots of places where there aren't trailing commas. Use trailing commas throughout the files for consistency. PR-URL: #25739 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.eslintrc has lots of trailing commas and lots of places where there
aren't trailing commas. Use trailing commas throughout the files for
consistency.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes