test: move test-exec.js out of pummel#25686
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Move test/pummel/test-exec.js to test/sequential/test-child-process-exec.js. The test does not seem to use too much resources to be put in sequential. (It does, at least as written, fail if it has too many other things to compete with, so let's leave it in sequential for now rather than parallel.)
Member
Author
addaleax
approved these changes
Jan 24, 2019
Member
There was a problem hiding this comment.
Looks like something that we could also put into parallel if we want?
It does, however, fail locally for me on master, most likely because of @Fishrock123’s freshly-landed #24951?
addaleax
added
the
child_process
Contributor
|
@addaleax Make sure you grab latest master, it has a fix. |
Fishrock123
suggested changes
Jan 24, 2019
Contributor
Fishrock123
left a comment
Fishrock123
left a comment
There was a problem hiding this comment.
Do we need to do this? Do we even need this test? What isn't covered by existing parallel/test-child-processes-exec* tests?
Code coverage doesn't seem to indicate anything glaring..
Member
Author
I'd be OK removing it. |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 26, 2019
Remove redundant test/pummel/test-exec.js. Refs: nodejs#25686 (review)
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 28, 2019
Remove redundant test/pummel/test-exec.js. Refs: nodejs#25686 (review) PR-URL: nodejs#25722 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
Author
|
Closed in favor of #25722 |
addaleax
pushed a commit
that referenced
this pull request
Jan 28, 2019
Remove redundant test/pummel/test-exec.js. Refs: #25686 (review) PR-URL: #25722 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move test/pummel/test-exec.js to
test/sequential/test-child-process-exec.js. The test does not seem to
use too much resources to be put in sequential. (It does, at least as
written, fail if it has too many other things to compete with, so let's
leave it in sequential for now rather than parallel.)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes