doc: link nextTick docs to the nextTick guide#25619
Closed
sam-github wants to merge 1 commit intonodejs:masterfrom
Closed
doc: link nextTick docs to the nextTick guide#25619sam-github wants to merge 1 commit intonodejs:masterfrom
sam-github wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
doc
addaleax
approved these changes
Jan 21, 2019
vsemozhetbyt
approved these changes
Jan 21, 2019
cjihrig
approved these changes
Jan 21, 2019
sam-github
force-pushed
the
link-to-nexttick-guide
branch
from
aed8ae8 to
9fcca08
Compare
lpinca
approved these changes
Jan 21, 2019
Link the guide discussing timers and nextTick from the nextTick docs, as it already was from the timers docs. Make the link text and targets more specific.
sam-github
force-pushed
the
link-to-nexttick-guide
branch
from
9fcca08 to
04ab222
Compare
Fishrock123
approved these changes
Jan 24, 2019
Contributor
Author
Contributor
Author
|
Landed in 102d923 |
sam-github
added a commit
that referenced
this pull request
Jan 25, 2019
Link the guide discussing timers and nextTick from the nextTick docs, as it already was from the timers docs. Make the link text and targets more specific. PR-URL: #25619 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jan 28, 2019
Link the guide discussing timers and nextTick from the nextTick docs, as it already was from the timers docs. Make the link text and targets more specific. PR-URL: #25619 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link the guide discussing timers and nextTick from the nextTick docs, as
it already was from the timers docs.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes