Closed
Conversation
nodejs-github-bot
added
the
crypto
Member
Author
|
Node.js collaborators, please 👍 here to approve fast-tracking. |
This was referenced Jan 18, 2019
Merged
lpinca
approved these changes
Jan 18, 2019
BridgeAR
approved these changes
Jan 18, 2019
Member
|
Landed in 9315daa 🎉 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 18, 2019
PR-URL: nodejs#25562 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
that referenced
this pull request
Jan 23, 2019
PR-URL: #25562 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I guess I don't need to say much about the commit itself. This causes the crash described in a comment in #25217, so it would be awesome if this could make it into 11.7.0 somehow, cc @BridgeAR.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes