[v10.x backport] src: re-sort the symbol macros#25500
Closed
sam-github wants to merge 1 commit intonodejs:v10.x-stagingfrom
Closed
[v10.x backport] src: re-sort the symbol macros#25500sam-github wants to merge 1 commit intonodejs:v10.x-stagingfrom
sam-github wants to merge 1 commit intonodejs:v10.x-stagingfrom
Conversation
Collaborator
|
@sam-github sadly an error occured when I tried to trigger a build :( |
nodejs-github-bot
added
c++
sam-github
force-pushed
the
backport-24382-to-10.x
branch
from
7898552 to
e645bcf
Compare
2 tasks
MylesBorins
force-pushed
the
v10.x-staging
branch
from
c1ee936 to
c6cffad
Compare
codebytere
force-pushed
the
v10.x-staging
branch
3 times, most recently
from
2d6e145 to
7840f71
Compare
The symbol macros were almost lexically sorted, but some were misplaced. Backport-PR-URL: nodejs#25500 PR-URL: nodejs#24382 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
sam-github
force-pushed
the
backport-24382-to-10.x
branch
from
e645bcf to
c76c3c9
Compare
Contributor
Author
|
@BethGriggs rebased cleanly |
BethGriggs
pushed a commit
that referenced
this pull request
Feb 5, 2019
The symbol macros were almost lexically sorted, but some were misplaced. Backport-PR-URL: #25500 PR-URL: #24382 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Member
|
Landed on |
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
The symbol macros were almost lexically sorted, but some were misplaced. Backport-PR-URL: #25500 PR-URL: #24382 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The symbol macros were almost lexically sorted, but some were misplaced.
PR-URL: #24382
Reviewed-By: Gus Caplan me@gus.host
Reviewed-By: Refael Ackermann refack@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Franziska Hinkelmann franziska.hinkelmann@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes