[v10.x] deps: cherry-pick d9fbfeb from upstream V8#25330
[v10.x] deps: cherry-pick d9fbfeb from upstream V8#25330kjin wants to merge 1 commit intonodejs:v10.x-stagingfrom
Conversation
642db97 to
8404c54
Compare
8404c54 to
e5615a9
Compare
|
@ofrobots Seems like the CI failure is an unrelated flake: https://ci.nodejs.org/job/node-test-binary-windows/22973/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=0/ I've rebased to resolve conflicts in |
|
The CI looks good to me. @nodejs/backporters this is ready to land. |
c1ee936 to
c6cffad
Compare
2d6e145 to
7840f71
Compare
e5615a9 to
49b3a42
Compare
|
@nodejs/backporters -- could we land this please? Thanks! |
|
@nodejs/release @nodejs/backporters does the policy that only the backport team should be landing fixes on staging branches still make sense? Perhaps that is unnecessary burden on the team, and we should open this ability up to a broader list of collaborators to ensure things don't get stuck. Similarly: #25242. |
Discussion over in nodejs/Release#388. |
49b3a42 to
4088a6b
Compare
|
Could we get a review from @nodejs/v8?, then this should land ready for v10.15.2 |
There was a problem hiding this comment.
LGTM.
There were also LGTMs on #23886.
EDIT: launched a new CI: https://ci.nodejs.org/job/node-test-pull-request/20566/
Original commit message:
inspector: return [[StableObjectId]] as internal property
This property might be useful for fast '===' check.
R=dgozman@chromium.org,yangguo@chromium.org
Bug: none
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352
Reviewed-on: https://chromium-review.googlesource.com/1226411
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{nodejs#56095}
4088a6b to
a1b134a
Compare
|
Force-pushed to edit the commit message once again, seems like quoted commits need to be spaced 4 whitespaces instead of two. |
|
Landed on |
Original commit message:
inspector: return [[StableObjectId]] as internal property
This property might be useful for fast '===' check.
R=dgozman@chromium.org,yangguo@chromium.org
Bug: none
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352
Reviewed-on: https://chromium-review.googlesource.com/1226411
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56095}
PR-URL: #25330
Original commit message:
inspector: return [[StableObjectId]] as internal property
This property might be useful for fast '===' check.
R=dgozman@chromium.org,yangguo@chromium.org
Bug: none
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352
Reviewed-on: https://chromium-review.googlesource.com/1226411
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56095}
PR-URL: #25330
Original commit message:
See: #23886
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes