src: split LoadEnvironment() at startExecution()#25320
Closed
addaleax wants to merge 2 commits intonodejs:masterfrom
Closed
src: split LoadEnvironment() at startExecution()#25320addaleax wants to merge 2 commits intonodejs:masterfrom
LoadEnvironment() at startExecution()#25320addaleax wants to merge 2 commits intonodejs:masterfrom
Conversation
This makes it easier to cater to embedders which wish to skip the `startExecution()` part.
nodejs-github-bot
added
c++
joyeecheung
approved these changes
Jan 3, 2019
Member
joyeecheung
left a comment
joyeecheung
left a comment
There was a problem hiding this comment.
LGTM. I wonder if as a follow up we should put the JS land startExecution into a separate file..
bnoordhuis
approved these changes
Jan 3, 2019
| if (start_execution.IsEmpty()) return; | ||
| start_execution->Call( | ||
| env->context(), Undefined(env->isolate()), 0, nullptr); | ||
| env->set_start_execution_function(Local<Function>()); |
Member
There was a problem hiding this comment.
Maybe do this before the call to, er, Call() as an extra guard against recursive invocation?
Member
Author
There was a problem hiding this comment.
Done, but it requires some extra magic because of the way the env->...() getters work…
JungMinu
approved these changes
Jan 3, 2019
cjihrig
approved these changes
Jan 3, 2019
jasnell
approved these changes
Jan 3, 2019
fhinkel
approved these changes
Jan 5, 2019
Member
Author
addaleax
added
the
author ready
Member
Author
|
Landed in f6a1d88 |
addaleax
added a commit
that referenced
this pull request
Jan 6, 2019
This makes it easier to cater to embedders which wish to skip the `startExecution()` part. PR-URL: #25320 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
This makes it easier to cater to embedders which wish to skip the `startExecution()` part. PR-URL: nodejs#25320 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
addaleax
added a commit
that referenced
this pull request
Jan 15, 2019
This makes it easier to cater to embedders which wish to skip the `startExecution()` part. PR-URL: #25320 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
This makes it easier to cater to embedders which wish to skip the `startExecution()` part. PR-URL: nodejs#25320 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 17, 2019
This makes it easier to cater to embedders which wish to skip the `startExecution()` part. PR-URL: nodejs#25320 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier to cater to embedders which wish to skip
the
startExecution()part.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes