util: Remove exec, has been deprecated for years#2530
Closed
geek wants to merge 1 commit intonodejs:masterfrom
Closed
util: Remove exec, has been deprecated for years#2530geek wants to merge 1 commit intonodejs:masterfrom
geek wants to merge 1 commit intonodejs:masterfrom
Conversation
brendanashworth
added
util
Contributor
|
Adding this to the list of things to check. |
Contributor
|
LGTM |
Member
Author
|
@chrisdickinson do you have a tool that runs a check? If so, can you share the code? |
Member
|
@chrisdickinson could you check this one ? |
Member
|
@chrisdickinson ... ping. were you ever able to get around to this? |
Member
|
Putting this on the ctc-agenda tomorrow for a quick sanity check. Don't believe it's controversial at all but worth a double check |
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
geek
added a commit
that referenced
this pull request
Nov 18, 2015
PR-URL: #2530 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 4cf19ad. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been deprecated for years: https://github.com/joyent/node/blob/v0.8.28-release/lib/util.js#L480-L482