src: move InternalMakeCallback and MakeCallback into callback_scope.cc#25299
Closed
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Closed
src: move InternalMakeCallback and MakeCallback into callback_scope.cc#25299joyeecheung wants to merge 1 commit intonodejs:masterfrom
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
c++
Member
Author
|
hmm, or maybe an alternative solution is to put these in an api.cc ? @addaleax But that may result in another monolithic file as well.. EDIT: or maybe a |
devsnek
approved these changes
Jan 1, 2019
addaleax
approved these changes
Jan 1, 2019
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
I think it’s fine this way 👍
jasnell
approved these changes
Jan 1, 2019
Member
Author
joyeecheung
added
the
author ready
Member
|
This needs a rebase |
addaleax
removed
the
author ready
Since these are just wrappers on top of `InternalCallbackScope`, this makes the implementations easier to find.
joyeecheung
force-pushed
the
make-callback
branch
from
500f437 to
e301ca8
Compare
Member
Author
Contributor
|
Landed in e54d11e. |
danbev
pushed a commit
that referenced
this pull request
Jan 9, 2019
This commit moves InternalMakeCallback and MakeCallback into callback_scope.cc. Since these are just wrappers on top of `InternalCallbackScope`, this makes the implementations easier to find. #25299 PR-URL: #25299 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jan 15, 2019
This commit moves InternalMakeCallback and MakeCallback into callback_scope.cc. Since these are just wrappers on top of `InternalCallbackScope`, this makes the implementations easier to find. #25299 PR-URL: #25299 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
This commit moves InternalMakeCallback and MakeCallback into callback_scope.cc. Since these are just wrappers on top of `InternalCallbackScope`, this makes the implementations easier to find. nodejs#25299 PR-URL: nodejs#25299 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 17, 2019
This commit moves InternalMakeCallback and MakeCallback into callback_scope.cc. Since these are just wrappers on top of `InternalCallbackScope`, this makes the implementations easier to find. nodejs#25299 PR-URL: nodejs#25299 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since these are just wrappers on top of
InternalCallbackScope, thismakes the implementations easier to find.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes