[v10.x backport] tls: add min/max protocol version options#24979
Closed
sam-github wants to merge 2 commits intonodejs:v10.x-stagingfrom
Closed
[v10.x backport] tls: add min/max protocol version options#24979sam-github wants to merge 2 commits intonodejs:v10.x-stagingfrom
sam-github wants to merge 2 commits intonodejs:v10.x-stagingfrom
Conversation
nodejs-github-bot
added
lib / src
Contributor
Author
|
ci: https://ci.nodejs.org/job/node-test-pull-request/19455/ @nodejs/lts @nodejs/crypto |
rvagg
added
crypto
rvagg
approved these changes
Dec 18, 2018
Member
rvagg
left a comment
rvagg
left a comment
There was a problem hiding this comment.
👌 sweet, I don't recall the rules but I think it needs to be live in 11.x for a release or two before going in. Also tagged as semver-minor which may conflict with plans for 10.x, but this really needs to happen because we're running out of time on 1.1.1.
Contributor
|
Our next semver minor isn't planned until march... should we do it earlier? |
Contributor
Author
|
no hurry, it's a pre-req for openssl-1.1.1, but can land in the same semver-minor as the openssl update |
MylesBorins
force-pushed
the
v10.x-staging
branch
from
17f4208 to
d04c3c2
Compare
sam-github
force-pushed
the
backport-tls-min-max-to-10.x
branch
from
4d4c651 to
0b06887
Compare
MylesBorins
force-pushed
the
v10.x-staging
branch
from
c1ee936 to
c6cffad
Compare
codebytere
force-pushed
the
v10.x-staging
branch
3 times, most recently
from
2d6e145 to
7840f71
Compare
Merged
BethGriggs
force-pushed
the
v10.x-staging
branch
from
13f9356 to
5711238
Compare
sam-github
force-pushed
the
backport-tls-min-max-to-10.x
branch
from
0b06887 to
d06c259
Compare
Fill in correct pr-url: value in the YAML changelog that was missing from f512f5e. The stanza was also sorted in the wrong order, most recent is supposed to be in the beginning of the changes, not the end. PR-URL: nodejs#24759 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The existing secureProtocol option only allows setting the allowed protocol to a specific version, or setting it to "all supported versions". It also used obscure strings based on OpenSSL C API functions. Directly setting the min or max is easier to use and explain. Backport-PR-URL: nodejs#24676 PR-URL: nodejs#24405 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
sam-github
force-pushed
the
backport-tls-min-max-to-10.x
branch
from
d06c259 to
a8a0889
Compare
Contributor
Author
|
Closed in favour of #26270 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of a backport... prep work for openssl 1.1.1 to land on v10.x
The existing secureProtocol option only allows setting the allowed
protocol to a specific version, or setting it to "all supported
versions". It also used obscure strings based on OpenSSL C API
functions. Directly setting the min or max is easier to use and explain.
Backport-PR-URL: #24676
PR-URL: #24405
Reviewed-By: Refael Ackermann refack@gmail.com
Reviewed-By: Rod Vagg rod@vagg.org
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes