doc: remove bad link to irc info#24967
Closed
richardlau wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Remove a link that no longer appears to point to information about Node.js IRC channels.
Member
Author
|
I'm open to replacing the link if someone has a suitable alternative. The current link is actually blocked at work for being pornographic (and a colleague has confirmed that it's not an inaccurate categorization). WHOIS suggests the domain was recently created/updated (perhaps the old registration expired?): https://whois.icann.org/en/lookup?name=nodeirc.info |
devsnek
approved these changes
Dec 11, 2018
Member
devsnek
left a comment
devsnek
left a comment
There was a problem hiding this comment.
yes this link is definitely not something that should be in our readme
Member
|
Node Collaborators, 👍 here to fast-track |
Member
|
As alternative, we can consider to using webchat: which is used in website: https://nodejs.org/en/get-involved/ |
Member
|
@watilde the current link is |
watilde
approved these changes
Dec 11, 2018
Trott
approved these changes
Dec 11, 2018
Member
|
Landed in 8c290fd |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 11, 2018
Remove a link that no longer appears to point to information about Node.js IRC channels. PR-URL: nodejs#24967 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 17, 2018
Remove a link that no longer appears to point to information about Node.js IRC channels. PR-URL: #24967 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Remove a link that no longer appears to point to information about Node.js IRC channels. PR-URL: nodejs#24967 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
Remove a link that no longer appears to point to information about Node.js IRC channels. PR-URL: #24967 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Feb 20, 2019
Remove a link that no longer appears to point to information about Node.js IRC channels. PR-URL: #24967 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Remove a link that no longer appears to point to information about Node.js IRC channels. PR-URL: #24967 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove a link that no longer appears to point to information about
Node.js IRC channels.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes