lib: move setupAllowedFlags() into per_thread.js#24704
Closed
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Closed
lib: move setupAllowedFlags() into per_thread.js#24704joyeecheung wants to merge 1 commit intonodejs:masterfrom
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
process
Because most of its code (the getter) has nothing to do with the actual bootstrapping and it is run per-thread.
joyeecheung
force-pushed
the
move-flags
branch
from
50d48a8 to
e48df20
Compare
Member
Author
Member
Author
|
Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19064/ ✔️ |
Member
Author
|
@addaleax @boneskull @nodejs/process Can I have some review please? Thanks! |
addaleax
approved these changes
Nov 30, 2018
joyeecheung
added
the
author ready
Member
Author
|
Landed in 36f483b, thanks! |
joyeecheung
added a commit
that referenced
this pull request
Nov 30, 2018
Because most of its code (the getter) has nothing to do with the actual bootstrapping and it is run per-thread. PR-URL: #24704 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Christopher Hiller <boneskull@boneskull.com>
BridgeAR
pushed a commit
that referenced
this pull request
Dec 5, 2018
Because most of its code (the getter) has nothing to do with the actual bootstrapping and it is run per-thread. PR-URL: #24704 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Christopher Hiller <boneskull@boneskull.com>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Because most of its code (the getter) has nothing to do with the actual bootstrapping and it is run per-thread. PR-URL: nodejs#24704 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Christopher Hiller <boneskull@boneskull.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
Because most of its code (the getter) has nothing to do with the actual bootstrapping and it is run per-thread. PR-URL: #24704 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Christopher Hiller <boneskull@boneskull.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Because most of its code (the getter) has nothing to do with the actual bootstrapping and it is run per-thread. PR-URL: #24704 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Christopher Hiller <boneskull@boneskull.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because most of its code (the getter) has nothing to do with
the actual bootstrapping and it is run per-thread.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes