Skip to content

build: replace -not with ! in find#24635

Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Trott:notnotnot
Closed

build: replace -not with ! in find#24635
Trott wants to merge 1 commit intonodejs:masterfrom
Trott:notnotnot

Conversation

@Trott
Copy link
Member

@Trott Trott commented Nov 25, 2018

Replace find -not usage with find ! as -not is not universally
supported.

Fixes: #24634

@nodejs/build-files @rvagg @nodejs/platform-aix

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
build: replace -not with ! in find
5b91604 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: nodejs#24634
@Trott Trott added build Issues and PRs related to build files or the CI. aix Issues and PRs related to the AIX platform. fast-track PRs that do not need to wait for 48 hours to land. labels Nov 25, 2018
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 25, 2018

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1698/pipeline

@Trott
Copy link
Member Author

Trott commented Nov 25, 2018

👍 here to fast-track

@Trott Trott mentioned this pull request Nov 25, 2018
Closed
@Trott
Copy link
Member Author

Trott commented Nov 25, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18957/

@Trott
Copy link
Member Author

Trott commented Nov 25, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18959/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 25, 2018
@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 25, 2018

landed as e20be47

gireeshpunathil pushed a commit that referenced this pull request Nov 25, 2018
@Trott @gireeshpunathil
build: replace -not with ! in find
e20be47 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: #24634
PR-URL: #24635
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this pull request Nov 27, 2018
@Trott @targos
build: replace -not with ! in find
059d9c7 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: #24634
PR-URL: #24635
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@Trott @rvagg
build: replace -not with ! in find
3fa4def 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: #24634
PR-URL: #24635
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@Trott @refack
build: replace -not with ! in find
edcc4e6 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: nodejs#24634
PR-URL: nodejs#24635
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs pushed a commit that referenced this pull request Feb 11, 2019
@Trott @BethGriggs
build: replace -not with ! in find
95a3b3e 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: #24634
PR-URL: #24635
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@Trott @rvagg
build: replace -not with ! in find
748de6b 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: #24634
PR-URL: #24635
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@Trott Trott deleted the notnotnot branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees

No one assigned

Labels

aix Issues and PRs related to the AIX platform. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AIX bug in Makefile - find with -not

6 participants

@Trott @nodejs-github-bot @gireeshpunathil @lpinca @richardlau @BethGriggs