Skip to content

src: replace array implementation#24614

Closed
kazupon wants to merge 1 commit intonodejs:masterfrom
kazupon:fix-array-uv
Closed

src: replace array implementation#24614
kazupon wants to merge 1 commit intonodejs:masterfrom
kazupon:fix-array-uv

Conversation

@kazupon
Copy link
Contributor

@kazupon kazupon commented Nov 24, 2018

replace with C++ API.

Refs: #24125

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. libuv Issues and PRs related to the libuv dependency or the uv binding. labels Nov 24, 2018
@addaleax
Copy link
Member

addaleax commented Nov 24, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18922/

@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 24, 2018
@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 24, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18936

@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 24, 2018 •
edited
Loading

fast-track? pls 👍

edited to strike this off; normal code changes not eligible for fast-tracking under normal conditions.

devsnek
devsnek approved these changes Nov 25, 2018
View reviewed changes
Copy link
Member

@devsnek devsnek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but once again, normal code changes really shouldn't be fast tracked

@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 25, 2018

@devsnek @apapirovski thanks for the correction, it was un-intentional! I struck the suggestion off.

btw, Is there another PR around where I did the same mistake? From your description I felt so but unable to find one. Please let me know.

@devsnek
Copy link
Member

devsnek commented Nov 25, 2018

@gireeshpunathil it was another code and learn pr, i don't think it was you specifically though. apologies now that i see how that message could be interpreted.

@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 26, 2018

landed as 4d3ee75

thank you @kazupon for the contribution! Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps

gireeshpunathil pushed a commit that referenced this pull request Nov 26, 2018
@kazupon @gireeshpunathil
src: replace array implementation
4d3ee75 
replace with C++ API.

Refs: #24125
PR-URL: #24614
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@kazupon kazupon deleted the fix-array-uv branch November 27, 2018 01:25
targos pushed a commit that referenced this pull request Nov 27, 2018
@kazupon @targos
src: replace array implementation
24ca24a 
replace with C++ API.

Refs: #24125
PR-URL: #24614
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@kazupon @rvagg
src: replace array implementation
dca1ecf 
replace with C++ API.

Refs: #24125
PR-URL: #24614
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@kazupon @refack
src: replace array implementation
cec66ec 
replace with C++ API.

Refs: nodejs#24125
PR-URL: nodejs#24614
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

+1 more reviewer

@devsnek devsnek devsnek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. libuv Issues and PRs related to the libuv dependency or the uv binding.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@kazupon @addaleax @gireeshpunathil @devsnek @cjihrig @joyeecheung @BethGriggs @nodejs-github-bot