test: fixed the arguments order in assert.strictEqual

[sota1235]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[gireeshpunathil]

CI: https://ci.nodejs.org/job/node-test-pull-request/18933/

[gireeshpunathil]

fast-track? pls 👍

[gireeshpunathil]

only failure in windows-fanned test_threadsafe_function is known - #23621

[gireeshpunathil]

landed as f351c5d , thanks!

[Trott]

only failure in windows-fanned test_threadsafe_function is known - #23621

Per the Collaborators Guide, we may not land without a green or yellow CI. Please don't disregard failures, including known failures. (If they are to be disregarded, they need to be marked in the status file, which will result in a yellow CI when they fail.) Thanks.

[gireeshpunathil]

@Trott - thanks for the correction! I did not know that we should not land even when the failing test has an open issue on it. I will follow that route.

the relevant section in the guide, however is not explicit on it and assumes that the failing job is flaky and may recover from a resume build option? In this case no point of using resume build as we know it to fail?

Do not land any Pull Requests without passing (green or yellow) CI runs. If you believe any failed (red or grey) CI sub-tasks are unrelated to the change in the Pull Request, use "Resume Build" in the left navigation of the relevant node-test-pull-request job. It will create a new node-test-pull-request run that preserves all the green results from the current job but re-runs everything else.

[Trott]

I believe Resume Build now works in all cases including the fanned jobs. (If it doesn't, definitely notify Build WG. Or just use Rebuild instead of Resume Build. Or both.)