docs: fix replace anonymous function with arrow function#24606
Closed
taminif wants to merge 2 commits intonodejs:masterfrom
Closed
docs: fix replace anonymous function with arrow function#24606taminif wants to merge 2 commits intonodejs:masterfrom
taminif wants to merge 2 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
async_hooks
shisama
added
the
code-and-learn
ronkorving
approved these changes
Nov 24, 2018
joyeecheung
approved these changes
Nov 24, 2018
vsemozhetbyt
approved these changes
Nov 24, 2018
Contributor
vsemozhetbyt
left a comment
vsemozhetbyt
left a comment
There was a problem hiding this comment.
With nit that can be fixed on landing.
Contributor
vsemozhetbyt
added
the
author ready
Contributor
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
Contributor
|
@taminif It seems the email in your commit is not included in your GitHub settings. From our contributing guide:
|
gireeshpunathil
approved these changes
Nov 24, 2018
vsemozhetbyt
added
the
fast-track
Trott
added
author ready
Member
Author
|
@vsemozhetbyt Sorry I checked email. I didn't have much time to fixed reviews. @Trott Thanks for fixing bug! |
Member
|
Please remove "anonymous" from the commit message while landing. The functions previously were not anonymous. |
Member
Member
|
Landed in e958ee7 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 26, 2018
PR-URL: nodejs#24606 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Member
|
Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
targos
pushed a commit
that referenced
this pull request
Nov 27, 2018
PR-URL: #24606 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #24606 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24606 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 11, 2019
PR-URL: #24606 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #24606 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes