test: removed third argument in assert.strictEqual() in test/addons-napi/test_env_sharing/test.js#24584
Closed
susantruong wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
nodejs-github-bot
added
node-api
cjihrig
approved these changes
Nov 24, 2018
susantruong
force-pushed
the
removeThirdArg-test-env-sharing
branch
from
1de4476 to
89736f3
Compare
Member
Trott
approved these changes
Nov 24, 2018
Trott
added
the
author ready
Member
|
Collaborators, 👍 here to fast-track. |
addaleax
approved these changes
Nov 24, 2018
gireeshpunathil
approved these changes
Nov 24, 2018
Member
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18909/ |
trivikr
reviewed
Nov 24, 2018
Member
There was a problem hiding this comment.
Suggested change
nit: line no. 9 can be removed, as the comment is related to assert.strictEqual
Member
susantruong
force-pushed
the
removeThirdArg-test-env-sharing
branch
from
0c1b3a5 to
a292879
Compare
Contributor
Author
|
I already fixed the commit message and all checks have passed. |
trivikr
approved these changes
Nov 26, 2018
Contributor
Author
|
@Trott Would you please grant me the overall/read permission? |
Contributor
Author
|
@Trott You gave me the link about CI, but I couldn't view it. |
Member
It's locked down right now for a security release. It will be available again in a few hours. |
Member
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18970/ |
Member
Member
|
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/18984/ |
Member
|
Landed in 1066b68. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 28, 2018
PR-URL: nodejs#24584 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #24584 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24584 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
PR-URL: #24584 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #24584 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am new to Node. I followed this Node Todo to start working on this nodejs project. Also, I followed the instruction Building Node.js on supported platforms to build and run the test before submitting this PR.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes