src: add DCHECK macros

[joyeecheung]

The first commit adds DCHECK macros that are only enabled in debug build and are noops in release buidls.

The second commit refactors StreamBase::CallJSOnreadMethod to use DCHECK instead of a ifdef DEBUG switch.

Reasoning: IMO it's slightly more readable to use DCHECK and it's a utility commonly used in V8 - we can be more generous about adding checks for the debug builds as general assertions to help finding subtle bugs.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows [commit guidelines]
  (https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)

[nodejs-github-bot]

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1674/pipeline

[joyeecheung]

CI: https://ci.nodejs.org/job/node-test-pull-request/18870/
CI: https://ci.nodejs.org/job/node-test-pull-request/18871/

[refack]

I like the idea. But why not use gsl::Expects and gsl::Ensure since they are most probably going to become part of the language? https://en.cppreference.com/w/cpp/language/attributes/contract

P.S. I think what I like about contracts the most is that they are clear about their place (either pre or post conditions) so no one will be tempted to do:

DCHECK(Object.Set(value))

[joyeecheung]

@refack Isn't that more like an idea for refactoring CHECK macros? Also are those features stable enough? Also, I find the documentation very confusing, it reads like someone talking to themsevels: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Ri-expects

[refack]

As for stability IIUC they are implemented as close to the new standard as possible (they can even be used by static analysers like clang-tidy)
They can be conditionally turned off (with a Define) with full standard implementation you can define their level (default or audit)
As for documentation at least there is some ¯_(ツ)_/¯

But yeah, it's just something to consider... I like the PR anyway.

[addaleax]

I know the PR title isn’t very descript, but I think this has a lot of overlap with #24359 ?

[joyeecheung]

@addaleax Ah yes, sorry I didn't notice about the ping earlier. I will close this one out.