test: replace callback function with arrow function#24531
Closed
potham wants to merge 1 commit intonodejs:masterfrom
potham:feature
Closed
test: replace callback function with arrow function#24531potham wants to merge 1 commit intonodejs:masterfrom potham:feature
potham wants to merge 1 commit intonodejs:masterfrom
potham:feature
Conversation
cjihrig
approved these changes
Nov 20, 2018
Trott
previously requested changes
Nov 20, 2018
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
The two commits here seem unrelated. Can you please remove the one you did not intend to include? Thanks.
gireeshpunathil
added
the
code-and-learn
Contributor
Author
|
@Trott I have removed the unrelated commit from this PR. Please excuse me.. |
gireeshpunathil
approved these changes
Nov 21, 2018
Member
Trott
added
the
author ready
Member
Member
|
Resume Build CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/22638/ |
Member
|
last CI succeeded, landing. |
Member
|
landed as f85b435 |
gireeshpunathil
pushed a commit
that referenced
this pull request
Nov 23, 2018
PR-URL: #24531 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 24, 2018
PR-URL: #24531 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #24531 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Dec 7, 2018
codebytere
pushed a commit
that referenced
this pull request
Jan 13, 2019
PR-URL: #24531 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24531 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
PR-URL: #24531 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
PR-URL: #24531 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes