test: replace anonymous function with arrow function

[codegagan]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[Trott]

While these kinds of commits are 👍 for first-contributions, I'm not sure they're of sufficient value to warrant a bunch of pull requests from existing contributors. I'd prefer people try to do something a bit more meaningful for subsequent commits. What do other Collaborators think?

(If we really want this type of thing to get done quickly instead of be a good exercise for new contributors, this is the type of thing that can be easily done with an ESLint rule and a --fix flag. )

[refack]

Hello @codegagan,
Now that your a "second timer", may we ask you to batch these sort of changes together. Having multiple PR increases our (and I'm assuming your) overhead.

Also be aware that you might get push-back. I think that is only natural, as we do expect more and more as you become more of an experienced contributor.

If I may suggest, we have a large list of stalled Issues and PR, you could take a look at those. They are things that could benefit the project, but need a champion to push them over the line.

[gireeshpunathil]

IIRC there were some code and learners whom we provided extra assignment slip(s) to be completed as home work as it was getting late in the evening on 17th and in case if they cannot do the first one due to its relatively complex nature (C++ code) - is this that category @codegagan ?

In either case, I concur to @Trott and @refack on the proposal on taking up bigger contribution ventures moving forward; at the same time feel happy to see @codegagan coming back to the repo. Wishing you great success with Node.js!

[gireeshpunathil]

ok, now looking at the PR list I see there are 5 or 6 - so these are not my assignments but hand-picks . In a way it is good that you were able to search and find things of your own, but it makes sense to be contented with the list of arrow function assignments as of now. :)

@codegagan - one thing that comes to my mind is preparing C++ code (/src) for v8 deprecation. Talking to @ryzokuken this is what it is I think:

• look at v8.h Search for methods with V8_DEPRECATE_SOON attributes
• look around in the neighborhood comments to seek alternatives - methods with slightly differing params or return values.
• search for usages of such deprecating methods in /src
• replace those with recommended versions.

/cc @ryzokuken to confirm my understanding / providing more direct instructions. thanks!

[codegagan]

@refack , @gireeshpunathil Thankyou for the guidance.

• This is the case of extra assignment slips(actually a page) which I took home. I thought it important to push this task as thats what organizers would expect since I have taken the slips.

• Reason for separate PRs instead of combined one: I clearly remember asking @thefourtheye at the event that why cannot we push all at once and he suggested that since it is unit of work and the good practice is to have separate. (Of course, it was overhead for me).

@gireeshpunathil regarding the v8 deprecation task, do you think it would be more appropriate to have instructions in an issue (than here) ? I can create one and paste these and then look into it.

[gireeshpunathil]

make sense to me, thanks!

[gireeshpunathil]

CI: https://ci.nodejs.org/job/node-test-pull-request/18876/

[danbev]

Re-run of failing node-test-commit-windows-fanned/.

[gireeshpunathil]

Resume CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/22701/

[gireeshpunathil]

windows-fanned->vs17->test-trace-events-api-worker-disabled is a known failure, landing.

[gireeshpunathil]

landed as db84fd2