Closed
Conversation
targos
added
the
code-and-learn
targos
approved these changes
Nov 17, 2018
Member
targos
left a comment
targos
left a comment
There was a problem hiding this comment.
Changes LGTM.
First commit message should start with test: fix ...
Member
|
👍 to fast-track |
trivikr
approved these changes
Nov 18, 2018
cjihrig
approved these changes
Nov 18, 2018
Member
jasnell
approved these changes
Nov 19, 2018
Trott
reviewed
Nov 19, 2018
Trott
previously requested changes
Nov 19, 2018
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
This one breaks tests. Please change back to a non-arrow function or fix the use of this to use another identifier for the expected object. Thanks!
Member
|
ping @apoorvanand |
apoorvanand
commented
Nov 22, 2018
| reader._read = () => {}; | ||
|
|
||
| writer1._write = common.mustCall(function(chunk, encoding, cb) { | ||
| writer1._write = common.mustCall((chunk, encoding, cb) => { |
Contributor
Author
There was a problem hiding this comment.
hey what I have to change in it
Contributor
Author
There was a problem hiding this comment.
changed back to non arrow function
Changed back to non arrow function to fix it
gireeshpunathil
approved these changes
Nov 23, 2018
Member
Member
|
@Trott - PTAL; code is good, and the tests are good too. |
Member
|
Landed in b5c5d20 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 28, 2018
PR-URL: nodejs#24441 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #24441 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24441 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
PR-URL: #24441 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #24441 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes