test: Replacing anonymous closure function with arrow function#24439
Closed
prabusubra wants to merge 6 commits intonodejs:masterfrom
prabusubra:testcodeimprovements
Closed
test: Replacing anonymous closure function with arrow function#24439prabusubra wants to merge 6 commits intonodejs:masterfrom prabusubra:testcodeimprovements
prabusubra wants to merge 6 commits intonodejs:masterfrom
prabusubra:testcodeimprovements
Conversation
gireeshpunathil
added
the
code-and-learn
addaleax
approved these changes
Nov 17, 2018
README.md
Outdated
| [Working Groups]: https://github.com/nodejs/TSC/blob/master/WORKING_GROUPS.md | ||
| [Strategic Initiatives]: https://github.com/nodejs/TSC/blob/master/Strategic-Initiatives.md | ||
| [#node.js channel on chat.freenode.net]: https://webchat.freenode.net?channels=node.js&uio=d4 | ||
|
|
Member
There was a problem hiding this comment.
I think this change is unrelated?
Contributor
Author
There was a problem hiding this comment.
Hi addaleax,
yes, this is mistake. i didn't observe the new line change.
Member
There was a problem hiding this comment.
@prabusubra - you may fix that by removing the extra line and repeating the last 3 steps for the PR process: git add <filename>, git commit , git push origin testcodeimprovements
Contributor
Author
There was a problem hiding this comment.
Done. Thanks Gireesh
cjihrig
approved these changes
Nov 17, 2018
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM with the README.md change backed out.
gireeshpunathil
approved these changes
Nov 18, 2018
trivikr
approved these changes
Nov 18, 2018
prabusubra
changed the title
jasnell
approved these changes
Nov 19, 2018
sagirk
approved these changes
Nov 19, 2018
thefourtheye
approved these changes
Nov 20, 2018
README.md
Outdated
| your expectations. | ||
|
|
||
| ## Release Types | ||
| ## Release Types |
Contributor
Author
There was a problem hiding this comment.
ok, you mean, i have to add trailing space for Release Types?
Member
Contributor
|
Landed in d88e26d. 🎉 |
danbev
pushed a commit
that referenced
this pull request
Nov 21, 2018
PR-URL: #24439 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 21, 2018
PR-URL: #24439 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #24439 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This was referenced Dec 7, 2018
codebytere
pushed a commit
that referenced
this pull request
Jan 13, 2019
PR-URL: #24439 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24439 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
PR-URL: #24439 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes