Closed
Conversation
oyyd
added
notable-change
gireeshpunathil
approved these changes
Nov 11, 2018
joyeecheung
approved these changes
Nov 11, 2018
addaleax
approved these changes
Nov 11, 2018
Contributor
Author
|
The CI building is appending. But it should be okay to land this. |
Member
|
@oyyd - apologies, I initiated a number of CI runs that were part of code&learn PRs, that probably caused your CI to be queued waiting for machines. I guess the recommended way here is: propose fast-tracking and seek approval from at least 2 collab's. I approve fast-tracking. |
Member
|
@gireeshpunathil This is an onboarding PR so I guess we don't necessarily need the fast-track thumbs-up process here...I'd say we can just land this as the CI run for this PR is just a formality (and to check that the collaborator can indeed start a CI run) Although ncu is correctly having trouble validating the status because there is no CI link in this thread (somehow it doesn't recognize the pipeline link posted by the bot - I will open an issue later). @oyyd started a job in Jenkins somehow it mysteriously disappeared before it enters the queue (I saw it was in pending status a while back). Anyway the link should've been https://ci.nodejs.org/job/node-test-pull-request/18529/ |
Member
|
@joyeecheung - sure, thanks for the clarification and sorry for any turbulence. |
Contributor
Author
|
Landed in 616125c. Thanks! |
BridgeAR
added a commit
that referenced
this pull request
Nov 14, 2018
Notable changes:
* child_process:
* All child processes will again open up a new Window on Windows by
default. [#24034](#24034)
* deps:
* A new and fast experimental HTTP parser (`llhttp`) is now supported.
[#24059](#24059)
* Added new collaborators:
* [oyyd](https://github.com/oyyd) - Ouyang Yadong.
[#24300](#24300)
* [psmarshall](https://github.com/psmarshall) - Peter Marshall.
[#24170](#24170)
* [shisama](https://github.com/shisama) - Masashi Hirano.
[#24136](#24136)
BridgeAR
added a commit
that referenced
this pull request
Nov 14, 2018
Notable changes:
* child_process:
* All child processes will again open up a new Window on Windows by
default. [#24034](#24034)
* deps:
* A new and fast experimental HTTP parser (`llhttp`) is now supported.
[#24059](#24059)
* **Windows**
* A crashing process will now show the names of stack frames if the
node.pdb file is available.
[#23822](#23822)
* Added new collaborators:
* [oyyd](https://github.com/oyyd) - Ouyang Yadong.
[#24300](#24300)
* [psmarshall](https://github.com/psmarshall) - Peter Marshall.
[#24170](#24170)
* [shisama](https://github.com/shisama) - Masashi Hirano.
[#24136](#24136)
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
PR-URL: nodejs#24300 Fixes: nodejs#23955 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Nov 15, 2018
Notable changes:
* deps:
* A new experimental HTTP parser (`llhttp`) is now supported.
#24059
* timers:
* Fixed an issue that could cause setTimeout to stop working as
expected. #24322
* Windows
* A crashing process will now show the names of stack frames if the
node.pdb file is available.
#23822
* Continued effort to improve the installer's new stage that installs
native build tools.
#23987,
#24348
* child_process:
* On Windows the `windowsHide` option default was restored to
`false`. This means `detached` child processes and GUI apps will
once again start in a new window.
#24034
* Added new collaborators:
* [oyyd](https://github.com/oyyd) - Ouyang Yadong.
#24300
* [psmarshall](https://github.com/psmarshall) - Peter Marshall.
#24170
* [shisama](https://github.com/shisama) - Masashi Hirano.
#24136
targos
pushed a commit
that referenced
this pull request
Nov 15, 2018
Notable changes:
* deps:
* A new experimental HTTP parser (`llhttp`) is now supported.
#24059
* timers:
* Fixed an issue that could cause setTimeout to stop working as
expected. #24322
* Windows
* A crashing process will now show the names of stack frames if the
node.pdb file is available.
#23822
* Continued effort to improve the installer's new stage that installs
native build tools.
#23987,
#24348
* child_process:
* On Windows the `windowsHide` option default was restored to
`false`. This means `detached` child processes and GUI apps will
once again start in a new window.
#24034
* Added new collaborators:
* [oyyd](https://github.com/oyyd) - Ouyang Yadong.
#24300
* [psmarshall](https://github.com/psmarshall) - Peter Marshall.
#24170
* [shisama](https://github.com/shisama) - Masashi Hirano.
#24136
PR-URL: #24350
This was referenced Nov 15, 2018
This was referenced Nov 15, 2018
Merged
codebytere
added a commit
that referenced
this pull request
Jan 29, 2019
codebytere
added a commit
that referenced
this pull request
Jan 29, 2019
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add me to collaborators.
/cc @joyeecheung
Fixes: #23955
Checklist