build: check minimum ICU in configure for system-icu#24255
Merged
refack merged 1 commit intonodejs:masterfrom Nov 17, 2018
Merged
build: check minimum ICU in configure for system-icu#24255refack merged 1 commit intonodejs:masterfrom
refack merged 1 commit intonodejs:masterfrom
Conversation
Member
Author
|
else you get this: also updates 'icu_system_version': '60.2',
'icu_ver_major': '60', |
srl295
commented
Nov 8, 2018
srl295
commented
Nov 8, 2018
devsnek
approved these changes
Nov 8, 2018
bnoordhuis
reviewed
Nov 8, 2018
Member
bnoordhuis
left a comment
There was a problem hiding this comment.
If nothing uses/is going to use icu_system_version, can you remove it?
Member
Author
|
@bnoordhuis I'll remove |
Member
Author
|
@bnoordhuis thanks. I think I addressed your comments. |
refack
approved these changes
Nov 8, 2018
jasnell
approved these changes
Nov 10, 2018
Member
|
@srl295 Looks like there's one nit from @bnoordhuis and a CI run and otherwise this is landable? Does that seem right to you? |
6695e84 to
2d0d9ce
Compare
Contributor
2d0d9ce to
5c47c2b
Compare
Contributor
- check the version number coming out of pkg-config PR-URL: nodejs#24255 Fixes: nodejs#24253 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
5c47c2b to
ed1c40e
Compare
This was referenced Dec 7, 2018
Merged
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #24253
make -j4 test(UNIX), orvcbuild test(Windows) passes