build,win: distribute the install-tools scripts in the zip by refack · Pull Request #24233 · nodejs/node

refack · 2018-11-07T21:46:49Z

pack install-tools.* into the zip
reroute MSI files sources

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2018-11-07T21:46:50Z

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1530/pipeline

joaocgreis

@refack the changes make sense, thanks! If you could test your changes locally before pushing, that would probably save us review cycles.

vcbuild.bat

tools/msvs/msi/product.wxs

refack · 2018-11-11T01:22:44Z

If you could test your changes locally before pushing, that would probably save us review cycles.

Sorry for the broken code, but I couldn't test this locally. IMHO we should cover this code in the test CI, since we have had some regressions, and maybe some more are hiding here ¯_(ツ)_/¯

Trott · 2018-11-20T06:19:03Z

@refack Still working on this (or planning to in any event)? Making sure we shouldn't apply the stalled or blocked labels (or help wanted) or anything like that...

refack · 2018-11-25T00:46:48Z

Build test release - https://ci-release.nodejs.org/job/iojs+release/3961/

refack · 2018-11-25T23:03:00Z

Tested manually and in https://ci-release.nodejs.org/job/iojs+release/3963/ ✔️
@joaocgreis PTAL

Trott · 2018-11-30T05:09:43Z

/ping @joaocgreis LGTY?

joaocgreis

Looks great now, thanks!

Trott · 2018-12-05T19:37:10Z

Since this touches vcbuild.bat, a generic CI seems in order:
https://ci.nodejs.org/job/node-test-pull-request/19235/

Trott · 2018-12-05T23:12:12Z

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19246/

Trott · 2018-12-06T02:58:11Z

Landed in 2fab5d5

PR-URL: nodejs#24233 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>

PR-URL: #24233 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>

Notable Changes: * console,util: * `console` functions now handle symbols as defined in the spec. #23708 * The inspection `depth` default is now back at 2. #24326 * dgram,net: * Added ipv6Only option for `net` and `dgram`. #23798 * http: * Chosing between the http parser is now possible per runtime flag. #24739 * readline: * The `readline` module now supports async iterators. #23916 * repl: * The multiline history feature is removed. #24804 * tls: * Added min/max protocol version options. #24405 * The X.509 public key info now includes the RSA bit size and the elliptic curve. #24358 * url: * `pathToFileURL()` now supports LF, CR and TAB. #23720 * Windows: * Tools are not installed using Boxstarter anymore. #24677 * The install-tools scripts or now included in the dist. #24233 * Added new collaborator: * [antsmartian](https://github.com/antsmartian) - Anto Aravinth. #24655 PR-URL: #24854

PR-URL: #24233 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>

Notable Changes: * console,util: * `console` functions now handle symbols as defined in the spec. #23708 * The inspection `depth` default is now back at 2. #24326 * dgram,net: * Added ipv6Only option for `net` and `dgram`. #23798 * http: * Chosing between the http parser is now possible per runtime flag. #24739 * readline: * The `readline` module now supports async iterators. #23916 * repl: * The multiline history feature is removed. #24804 * tls: * Added min/max protocol version options. #24405 * The X.509 public key info now includes the RSA bit size and the elliptic curve. #24358 * url: * `pathToFileURL()` now supports LF, CR and TAB. #23720 * Windows: * Tools are not installed using Boxstarter anymore. #24677 * The install-tools scripts or now included in the dist. #24233 * Added new collaborator: * [antsmartian](https://github.com/antsmartian) - Anto Aravinth. #24655 PR-URL: #24854

PR-URL: nodejs#24233 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>

Notable Changes: * console,util: * `console` functions now handle symbols as defined in the spec. nodejs#23708 * The inspection `depth` default is now back at 2. nodejs#24326 * dgram,net: * Added ipv6Only option for `net` and `dgram`. nodejs#23798 * http: * Chosing between the http parser is now possible per runtime flag. nodejs#24739 * readline: * The `readline` module now supports async iterators. nodejs#23916 * repl: * The multiline history feature is removed. nodejs#24804 * tls: * Added min/max protocol version options. nodejs#24405 * The X.509 public key info now includes the RSA bit size and the elliptic curve. nodejs#24358 * url: * `pathToFileURL()` now supports LF, CR and TAB. nodejs#23720 * Windows: * Tools are not installed using Boxstarter anymore. nodejs#24677 * The install-tools scripts or now included in the dist. nodejs#24233 * Added new collaborator: * [antsmartian](https://github.com/antsmartian) - Anto Aravinth. nodejs#24655 PR-URL: nodejs#24854

BethGriggs · 2019-09-03T15:50:36Z

Should this land on v10.x? Please open a backport PR if so

refack added windows Issues and PRs related to the Windows platform. install Issues and PRs related to the installers. build Issues and PRs related to build files or the CI. labels Nov 7, 2018

refack requested review from bzoz, joaocgreis and richardlau November 7, 2018 21:46

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 7, 2018

refack added semver-minor PRs that contain new features and should be released in the next minor version. and removed tools Issues and PRs related to the tools directory. labels Nov 7, 2018

refack mentioned this pull request Nov 7, 2018

Does not complete installation felixrieseberg/windows-build-tools#150

Open

richardlau approved these changes Nov 7, 2018

View reviewed changes

jasnell approved these changes Nov 10, 2018

View reviewed changes

joaocgreis suggested changes Nov 10, 2018

View reviewed changes

vcbuild.bat Outdated Show resolved Hide resolved

tools/msvs/msi/product.wxs Outdated Show resolved Hide resolved

build,win: pack the install-tools scripts for dist

8a49733

refack force-pushed the distribute-windows-install-tools-script branch from f786fad to e815709 Compare November 25, 2018 00:44

refack added the wip Issues and PRs that are still a work in progress. label Nov 25, 2018

build,win: tweak source paths in product.wxs

0c802c5

refack force-pushed the distribute-windows-install-tools-script branch from e815709 to 0c802c5 Compare November 25, 2018 22:57

refack removed the wip Issues and PRs that are still a work in progress. label Nov 25, 2018

joaocgreis approved these changes Dec 4, 2018

View reviewed changes

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 5, 2018

Trott closed this Dec 6, 2018

BridgeAR pushed a commit that referenced this pull request Dec 6, 2018

build,win: pack the install-tools scripts for dist

66602ad

PR-URL: #24233 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>

BridgeAR mentioned this pull request Dec 6, 2018

v11.4.0 proposal #24854

Merged

4 tasks

BridgeAR pushed a commit that referenced this pull request Dec 7, 2018

build,win: pack the install-tools scripts for dist

706bc41

PR-URL: #24233 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>

BridgeAR pushed a commit that referenced this pull request Dec 7, 2018

build,win: pack the install-tools scripts for dist

b80690d

PR-URL: #24233 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>

refack deleted the distribute-windows-install-tools-script branch December 21, 2018 01:12

refack restored the distribute-windows-install-tools-script branch January 22, 2019 21:42

BethGriggs added lts-watch-v10.x and removed lts-watch-v10.x labels Sep 3, 2019

Uh oh!

Conversation

refack commented Nov 7, 2018

Checklist

Uh oh!

nodejs-github-bot commented Nov 7, 2018

Uh oh!

joaocgreis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

refack commented Nov 11, 2018

Uh oh!

Trott commented Nov 20, 2018

Uh oh!

refack commented Nov 25, 2018

Uh oh!

refack commented Nov 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented Nov 30, 2018

Uh oh!

joaocgreis left a comment

Choose a reason for hiding this comment

Uh oh!

Trott commented Dec 5, 2018

Uh oh!

Trott commented Dec 5, 2018

Uh oh!

Trott commented Dec 6, 2018

Uh oh!

BethGriggs commented Sep 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

refack commented Nov 25, 2018 •

edited

Loading