test: esm loader unknown builtin module#24183
test: esm loader unknown builtin module#24183franher wants to merge 1 commit intonodejs:masterfrom franher:unknonw-builtin-module-error
Conversation
|
The test looks good to me, and we checked with @BridgeAR who believes it is a problem that he has seen and believes it is a bug in Node.js |
mhdawson
added
the
code-and-learn
|
Tests are now passing after fixing the resolve hook following @devsnek advice (#24175 (comment)). |
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
Thanks a lot for the awesome work!
|
@BridgeAR hello, do you know why the CI is failing at the linter phase? It is not indicating a linter error but a CI crash, imho. Thank you for your support. |
|
seems like the version of node on our ci doesn't support catch without a binding wrt Line 20 in 1f6c4ba |
|
Looking forward to see this PR landed :) |
|
@franher - sure, let me run a full CI and then we should be good to go. |
|
landed as 0229e37 , thanks! |
PR-URL: #24183 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #24183 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: nodejs#24183 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #24183 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
8 participants
Description
New test added as part of code-learn session. It should not land until #24175 is resolved.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes