Simple project messaging.#24
Simple project messaging.#24mikeal wants to merge 1 commit intonodejs:v0.12from mikeal:readme-messaging
Conversation
|
+1 for putting to bed "Evented I/O for V8 javascript", I've always hated that title |
|
your commit should be |
|
how do i alter commit messages after the fact? |
|
|
|
@TJkrusinski thanks! :) |
|
no problem! |
|
LGTM |
|
@mikeal Are you working on the governance section in https://github.com/mikeal/io.js/blob/readme-messaging/CONTRIBUTING.md#governance ? |
|
👍 |
There was a problem hiding this comment.
Agreed. I think it's supposed to say io.js is under the "open governance model" but it reads like node.js is. Not trying to be nitpicky. This is a pretty important paragraph.
There was a problem hiding this comment.
@kevinohara80 +1, would you or @KyleAMathews mind putting in a PR to clarify this?
Reviewed-By: Fedor Indutny <fedor@indutny.com> PR-URL: #24
|
Landed in 51514c8! Thank you. |
rewords project messaging in README to make the overall project messaging a bit clearer. More discussion to be found in nodejs#24
- Use undefined instead of null for lazy-loaded SEAProvider - Add validateBoolean for moduleHooks and virtualCwd options - Use template literal for path concatenation - Convert VirtualReadStream to use private class fields - Cache DateNow() result in MemoryEntry constructor Addresses review comments nodejs#18, nodejs#19, nodejs#21, nodejs#23, nodejs#24, nodejs#29.
- Use undefined instead of null for lazy-loaded SEAProvider - Add validateBoolean for moduleHooks and virtualCwd options - Use template literal for path concatenation - Convert VirtualReadStream to use private class fields - Cache DateNow() result in MemoryEntry constructor Addresses review comments nodejs#18, nodejs#19, nodejs#21, nodejs#23, nodejs#24, nodejs#29.
8 participants
This should put to bed some of the wilder speculation we've seen.