test: fixed error message in test-buffer-read module#23957
test: fixed error message in test-buffer-read module#23957arvind3157 wants to merge 3 commits intonodejs:masterfrom arvind3157:test/fix_error_message_buffer_module
Conversation
Trott
added
the
author ready
test/parallel/test-buffer-read.js
Outdated
| RangeError); | ||
| assert.throws( | ||
| () => Buffer.allocUnsafe(8).readFloatBE(0xffffffff), | ||
| { |
There was a problem hiding this comment.
The following object can be stored in a variable and can be passed as a second argument:
{
name: 'RangeError [ERR_OUT_OF_RANGE]'
}
Same applies to this object on line 89 and 96:
{
name: 'RangeError [ERR_BUFFER_OUT_OF_BOUNDS]',
message: 'Attempt to write outside buffer bounds'
}
There was a problem hiding this comment.
Thanks @trivikr I will do the changes and commit.
There was a problem hiding this comment.
I see I missed the point. I had to parametrize the object, not the value. Pushing the changes in next commit.
|
Most of the tests passed. It failed for windows. Any known issue or something I should worry about why this is failing? |
Certainly unrelated. I've opened #24005 about it. Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18266/ |
PR-URL: nodejs#23957 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Landed in e35f671. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
PR-URL: #23957 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
6 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes