doc: moved test instructions to BUILDING.md#23949
Closed
trivikr wants to merge 3 commits intonodejs:masterfrom
Closed
doc: moved test instructions to BUILDING.md#23949trivikr wants to merge 3 commits intonodejs:masterfrom
trivikr wants to merge 3 commits intonodejs:masterfrom
Conversation
Fixes: nodejs#23491 Duplicate test instructions were present in pull-requests.md Merged the instructions in BUILDING.md and provided a link from pull-requests.md
nodejs-github-bot
added
build
danbev
approved these changes
Oct 29, 2018
jasnell
approved these changes
Oct 29, 2018
refack
approved these changes
Oct 29, 2018
Member
|
The coverage instructions should probably point out that it is non-Windows (AFAIK). Can be done in another PR as it wasn't in the original text. |
Trott
reviewed
Oct 29, 2018
Co-Authored-By: trivikr <16024985+trivikr@users.noreply.github.com>
fhinkel
approved these changes
Oct 30, 2018
jasnell
approved these changes
Oct 30, 2018
Member
Author
Member
Author
|
Landed in 8c244dd |
trivikr
added a commit
to trivikr/node
that referenced
this pull request
Oct 31, 2018
Fixes: nodejs#23491 Duplicate test instructions were present in pull-requests.md Merged the instructions in BUILDING.md and provided a link from pull-requests.md PR-URL: nodejs#23949 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 1, 2018
Fixes: #23491 Duplicate test instructions were present in pull-requests.md Merged the instructions in BUILDING.md and provided a link from pull-requests.md PR-URL: #23949 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This was referenced Nov 2, 2018
Contributor
|
This does not land cleanly on 8.x or 10.x As 8.x is near maintenance I'm setting as don't land, but perhaps we should backport to 10.x |
Member
Author
|
These test instructions are for working on NodeJS core, so it's good as long as they're in master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #23491
Duplicate test instructions were present in pull-requests.md
Merged the instructions in BUILDING.md and provided a link from
pull-requests.md
Checklist