deps: fix shim for v8::Value::IntegerValue()#23898
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
deps: fix shim for v8::Value::IntegerValue()#23898addaleax wants to merge 1 commit intonodejs:masterfrom
v8::Value::IntegerValue()#23898addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
This was introduced in 48d1335. Previously, values such as `undefined` would not be coerced properly because `NumberValue()` returns `NaN` for them. Refs: nodejs#23158
nodejs-github-bot
added
the
v8 engine
Member
Author
|
CI: https://ci.nodejs.org/job/node-test-pull-request/18168/ Please 👍 this comment to approve fast-tracking. This is also likely a good candidate for v11.0.1. |
addaleax
added
dont-land-on-v8.x
fast-track
targos
approved these changes
Oct 26, 2018
ryzokuken
approved these changes
Oct 26, 2018
cjihrig
approved these changes
Oct 26, 2018
refack
approved these changes
Oct 26, 2018
jasnell
approved these changes
Oct 26, 2018
Member
Author
|
Landed in ffa5c7e |
addaleax
added a commit
that referenced
this pull request
Oct 27, 2018
This was introduced in 48d1335. Previously, values such as `undefined` would not be coerced properly because `NumberValue()` returns `NaN` for them. Refs: #23158 PR-URL: #23898 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 27, 2018
This was introduced in 48d1335. Previously, values such as `undefined` would not be coerced properly because `NumberValue()` returns `NaN` for them. Refs: #23158 PR-URL: #23898 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 1, 2018
This was introduced in 48d1335. Previously, values such as `undefined` would not be coerced properly because `NumberValue()` returns `NaN` for them. Refs: #23158 PR-URL: #23898 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Nov 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was introduced in 48d1335. Previously, values such as
undefinedwould not be coerced properly becauseNumberValue()returns
NaNfor them.Refs: #23158
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes