doc: document key encryption options#23632
Closed
tniessen wants to merge 4 commits intonodejs:masterfrom
Closed
Conversation
nodejs-github-bot
added
crypto
mscdex
reviewed
Oct 13, 2018
Contributor
|
/ping @nodejs/crypto |
sam-github
reviewed
Oct 15, 2018
Member
|
@tniessen Do you plan to follow up? This looks good to go once you incorporate the review feedback. |
tniessen
force-pushed
the
doc-document-keygen-encryption
branch
from
061ba26 to
a94f159
Compare
Member
Author
|
@nodejs/crypto @nodejs/documentation PTAL. |
mscdex
reviewed
Nov 26, 2018
sam-github
approved these changes
Nov 26, 2018
Contributor
sam-github
left a comment
sam-github
left a comment
There was a problem hiding this comment.
Text is informative, and LGTM. I leave it to you to decide to address (or not) the comment on duplicate docs.
tniessen
force-pushed
the
doc-document-keygen-encryption
branch
from
a94f159 to
464b674
Compare
Member
Author
|
Thanks for reviewing and sorry about the long delay, I figured it made sense to wait until the key object API had been finalized. That also took care of the duplication you were worried about, @sam-github. I didn't change the text itself, I just moved it to |
Trott
reviewed
Jan 4, 2019
sam-github
approved these changes
Jan 4, 2019
tniessen
changed the title
Member
Author
|
Landed in 345d3f3, thanks for reviewing! |
addaleax
pushed a commit
that referenced
this pull request
Jan 5, 2019
PR-URL: #23632 Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#23632 Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Merged
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
PR-URL: nodejs#23632 Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is very little documentation on the supported encryption options. This should be enough for most use cases.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes