build: restore js2c direct dependency on config.gypi#23355
Merged
refack merged 1 commit intonodejs:masterfrom Oct 10, 2018
Merged
build: restore js2c direct dependency on config.gypi#23355refack merged 1 commit intonodejs:masterfrom
refack merged 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
build
addaleax
approved these changes
Oct 9, 2018
joyeecheung
approved these changes
Oct 9, 2018
richardlau
approved these changes
Oct 9, 2018
danbev
approved these changes
Oct 10, 2018
Contributor
|
@refack Thanks for the quick fix! Could this be fast-tracked perhaps? |
Member
|
I think the blank line issue has been fixed in core-validate-commit (nodejs/core-validate-commit#29 (comment)) so I've restarted the Travis CI. |
2 tasks
Contributor
Contributor
Author
|
Need another 👍 for fast-tracking. |
PR-URL: nodejs#23355 Fixes: nodejs#23352 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
refack
force-pushed
the
fix-js2c-config.gypi-dependenacy
branch
from
7bd8623 to
484e4db
Compare
Contributor
Author
|
Fast-tracked with 2 approvals. |
This was referenced Oct 10, 2018
This was referenced Oct 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #23352
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes