Fixed minor typo (to early -> too early)#23211
Closed
justin0022 wants to merge 2 commits intonodejs:masterfrom
Closed
Fixed minor typo (to early -> too early)#23211justin0022 wants to merge 2 commits intonodejs:masterfrom
justin0022 wants to merge 2 commits intonodejs:masterfrom
Conversation
Trott
approved these changes
Oct 2, 2018
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
Did you intend to include both commits in this one PR? The #vcbuildbat one seems like a correct change but unrelated. Looks like you committed to your own master branch rather than a feature branch, so maybe that's part of the problem?
Contributor
Author
|
Hi Trott, my mistake, I meant to create a branch but pushed my change before I did so. Did you want me to break it up into two pull requests? Pretty minor changes. |
Member
My opinion only, but I'm fine with it the way it is. Both changes are very small, narrow, and should be uncontroversial. |
lundibundi
approved these changes
Oct 2, 2018
gireeshpunathil
approved these changes
Oct 2, 2018
vsemozhetbyt
approved these changes
Oct 2, 2018
Contributor
Contributor
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
vsemozhetbyt
added
the
author ready
lpinca
approved these changes
Oct 2, 2018
vsemozhetbyt
added
the
fast-track
vsemozhetbyt
pushed a commit
that referenced
this pull request
Oct 2, 2018
PR-URL: #23211 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
vsemozhetbyt
pushed a commit
that referenced
this pull request
Oct 2, 2018
PR-URL: #23211 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Contributor
|
Landed in 9b34dfe...250957b |
targos
pushed a commit
that referenced
this pull request
Oct 3, 2018
PR-URL: #23211 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 3, 2018
PR-URL: #23211 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Oct 10, 2018
This was referenced Oct 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change, fixed a typo from 'to early' to 'too early'.
Checklist