doc: add contents table to CONTRIBUTING.md#23140
Closed
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:md
Closed
doc: add contents table to CONTRIBUTING.md#23140ZYSzys wants to merge 1 commit intonodejs:masterfrom zys-contrib:md
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:md
Conversation
Member
|
I'm not opposed to this but the file is very small so I think it's not very useful. |
jasnell
approved these changes
Sep 28, 2018
trivikr
approved these changes
Oct 1, 2018
Member
Member
|
Landed in 639ec83 |
trivikr
pushed a commit
that referenced
this pull request
Oct 1, 2018
PR-URL: #23140 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 3, 2018
PR-URL: #23140 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Oct 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add contents table to CONTRIBUTING.md so that user can index to the wanted contents,
such as the COLLABORATOR_GUIDE.md did.
Checklist