test-child-process-disconnected.js added more descriptive error message to test's assert

[Josh-Broomfield]

No description provided.

[gireeshpunathil]

hello @Josh-Broomfield - thanks for the PR. there is linter error reported:

test/parallel/test-child-process-disconnect.js
  97:42  error  Trailing spaces not allowed  no-trailing-spaces

can you fix that and push again? thanks. ( run make -j4 test that will catch all these types of issues)

[Trott]

can you fix that and push again? thanks. ( run make -j4 test that will catch all these types of issues)

And if you just want to quickly lint JS files only without running all the tests, you can use make lint-js.

[Trott]

Change looks good to me once lint issue is addressed.

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/17476/

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/17499/

[addaleax]

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17529/

[danbev]

Re-run of failing node-test-commit-linux ✔️
Re-run of failing node-test-commit-arm ✔️
Re-run of failing node-test-commit-linux-containered ✔️

[danbev]

Landed in 2f36cb4.

[Trott]

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

[Josh-Broomfield]

Could this be reopened please? I'd like to try a bunch of different things since I'm unfamiliar with open source.

[addaleax]

@Josh-Broomfield This pull request has been merged into our master branch – if you’d like to propose new changes, I think it would be best to do so with new pull request?

[Josh-Broomfield]

Oh sorry I figured since it failed some tests that it wasn't. I'll be looking into the next steps link then. Thanks.