test: add process.stdin.end() TTY regression test#23051
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
test: add process.stdin.end() TTY regression test#23051addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
test
mcollina
approved these changes
Sep 24, 2018
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
LGTM. Can you also include a revert for my semver-major fix retaining tests? It should not be needed anymore (another PR is also ok).
Member
Author
|
@mcollina Will do, but another PR might be easier since it’s going to be |
Member
|
I agree, ok!
Il giorno lun 24 set 2018 alle 11:18 Anna Henningsen <
notifications@github.com> ha scritto:
… @mcollina <https://github.com/mcollina> Will do, but another PR might be
easier since it’s going to be dont-land-on-v10.x…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23051 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADL45s-4Kx5XjQNr6YN6vveLcRNh3W0ks5ueKNsgaJpZM4W2SLd>
.
|
cjihrig
approved these changes
Sep 24, 2018
trivikr
approved these changes
Sep 26, 2018
lpinca
approved these changes
Sep 26, 2018
Contributor
addaleax
added
the
author ready
Member
Author
gdams
approved these changes
Sep 28, 2018
jasnell
approved these changes
Sep 28, 2018
Member
Author
Member
Author
Member
Author
|
Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17610/ ✔️ |
Contributor
|
Landed in 9577946. |
danbev
pushed a commit
that referenced
this pull request
Oct 4, 2018
PR-URL: #23051 Fixes: #22814 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 4, 2018
PR-URL: #23051 Fixes: #22814 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Oct 10, 2018
This was referenced Oct 11, 2018
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
PR-URL: #23051 Fixes: #22814 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Oct 23, 2018
BethGriggs
pushed a commit
that referenced
this pull request
Mar 19, 2019
Backport-PR-URL: #25351 PR-URL: #23051 Fixes: #22814 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
abhishekumar-tyagi
pushed a commit
to abhishekumar-tyagi/node
that referenced
this pull request
May 5, 2024
PR-URL: nodejs/node#23051 Fixes: nodejs/node#22814 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #22814
Taken from @mcollina’s #22900.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes