src: simplify MessagePort construction code a bit#23036
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
src: simplify MessagePort construction code a bit#23036addaleax wants to merge 1 commit intonodejs:masterfrom
MessagePort construction code a bit#23036addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
c++
Member
Author
|
CI: https://ci.nodejs.org/job/node-test-pull-request/17383/ (Only edited the commit message since CI was started) |
devsnek
approved these changes
Sep 23, 2018
Using `ASSIGN_OR_RETURN_UNWRAP` would return if the created `MessagePort` object had no internal fields. That would be a bug, so switch to a checked conversion instead.
addaleax
force-pushed
the
message-port-checked
branch
from
c872f67 to
5ae4469
Compare
Member
Author
addaleax
added
the
author ready
jasnell
approved these changes
Sep 23, 2018
cjihrig
approved these changes
Sep 24, 2018
joyeecheung
approved these changes
Sep 24, 2018
Member
Author
|
Landed in d102a85 |
addaleax
added a commit
that referenced
this pull request
Sep 25, 2018
Using `ASSIGN_OR_RETURN_UNWRAP` would return if the created `MessagePort` object had no internal fields. That would be a bug, so switch to a checked conversion instead. PR-URL: #23036 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 27, 2018
Using `ASSIGN_OR_RETURN_UNWRAP` would return if the created `MessagePort` object had no internal fields. That would be a bug, so switch to a checked conversion instead. PR-URL: #23036 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This was referenced Oct 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
ASSIGN_OR_RETURN_UNWRAPwould return if thecreated
MessagePortobject had no internal fields.That would be a bug, so switch to a checked conversion instead.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes