lib: Improve readability of help text in node --help#23016
lib: Improve readability of help text in node --help#23016gireeshpunathil merged 1 commit intonodejs:masterfrom
node --help#23016Conversation
|
I think the current text was intentional; reading from stdin is the default when no other file name is provided, and if stdin is a TTY we enter interactive mode? |
|
It seems the "reading from stdin" is wider than "interactive mode" (it may be a command chain), so this is a note about a partial case, not the definition of "default", and the semicolon seems valid. |
|
ah! I see it now, thanks for the clarification. |
|
@gireeshpunathil That doesn’t mean we can’t improve here … I agree that this is not immediately obvious. Maybe we could change it to something like |
|
I reworded the help message for better readability, PTAL. |
gireeshpunathil
changed the title
node --help
|
Re-run of failing node-test-commit-linux-containered and node-test-commit-linux/ |
|
rebased and started a new CI: https://ci.nodejs.org/job/node-test-pull-request/17491/ |
|
only one known failure under |
gireeshpunathil
added
the
cli
modified the `-` CLI option help text for improved readability. PR-URL: nodejs#23016 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
gireeshpunathil
force-pushed
the
default
branch
from
ac93f91 to
0f78b9a
Compare
modified the `-` CLI option help text for improved readability. PR-URL: #23016 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
modified the `-` CLI option help text for improved readability. PR-URL: #23016 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
9 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes