doc: synopsis-docs match Hello, World! example in console output.#23006
Closed
MohammedEssehemy wants to merge 1 commit intonodejs:masterfrom
Closed
doc: synopsis-docs match Hello, World! example in console output.#23006MohammedEssehemy wants to merge 1 commit intonodejs:masterfrom
MohammedEssehemy wants to merge 1 commit intonodejs:masterfrom
Conversation
vsemozhetbyt
approved these changes
Sep 21, 2018
Contributor
Contributor
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
vsemozhetbyt
added
the
author ready
Contributor
|
Line 13 seems also a bit off) |
Contributor
Author
|
@vsemozhetbyt which line do you mean? the only changed lines are 74 and 97. |
lpinca
approved these changes
Sep 21, 2018
Contributor
|
I mean that the unchanged line 13 can also be fixed if you want) |
vsemozhetbyt
added
the
fast-track
MohammedEssehemy
force-pushed
the
fix/synopsis-docs-typo
branch
from
f005766 to
1239dbe
Compare
Contributor
Author
|
@vsemozhetbyt Aha got it, I've changed it now. |
Contributor
Contributor
|
Landed in 5942a34 |
vsemozhetbyt
pushed a commit
that referenced
this pull request
Sep 21, 2018
PR-URL: #23006 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 23, 2018
PR-URL: #23006 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Oct 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix typo in console output for
Hello, World!example in synopsis docs.