src: refactor win32 DebugProcess() to use RAII cleanup#22981
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
src: refactor win32 DebugProcess() to use RAII cleanup#22981addaleax wants to merge 1 commit intonodejs:masterfrom
DebugProcess() to use RAII cleanup#22981addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
Prefer more idiomatic C++ cleanup code over `goto`.
nodejs-github-bot
added
the
c++
Member
Author
|
CI: https://ci.nodejs.org/job/node-test-pull-request/17345/ (:heavy_check_mark:) |
addaleax
added
the
lib / src
tniessen
approved these changes
Sep 20, 2018
eugeneo
approved these changes
Sep 20, 2018
bzoz
approved these changes
Sep 21, 2018
cjihrig
approved these changes
Sep 21, 2018
jasnell
approved these changes
Sep 21, 2018
lundibundi
added
the
author ready
4 tasks
gireeshpunathil
approved these changes
Sep 22, 2018
Member
Author
|
Landed in 59a8324 |
addaleax
added a commit
that referenced
this pull request
Sep 23, 2018
Prefer more idiomatic C++ cleanup code over `goto`. PR-URL: #22981 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos
pushed a commit
that referenced
this pull request
Sep 24, 2018
Prefer more idiomatic C++ cleanup code over `goto`. PR-URL: #22981 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This was referenced Oct 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer more idiomatic C++ cleanup code over
goto.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes (This was not written on Windows so CI will have to tell)