http2: check if stream is not destroyed before sending trailers#22896
Closed
mcollina wants to merge 1 commit intonodejs:masterfrom
Closed
http2: check if stream is not destroyed before sending trailers#22896mcollina wants to merge 1 commit intonodejs:masterfrom
mcollina wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
dont-land-on-v6.x
http2
Member
Author
BridgeAR
approved these changes
Sep 17, 2018
BridgeAR
added
the
author ready
cjihrig
approved these changes
Sep 17, 2018
jasnell
approved these changes
Sep 19, 2018
Member
Author
|
Landed in c9d4304 |
5 tasks
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Oct 3, 2018
Fixes: nodejs#22855 PR-URL: nodejs#22896 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Oct 10, 2018
This was referenced Oct 11, 2018
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Oct 16, 2018
Fixes: nodejs#22855 PR-URL: nodejs#22896 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22855.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes