deps: add missing HandleScope in FieldType::PrintTo

[hashseed]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes (https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)

[nodejs-github-bot]

@hashseed build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/903/pipeline

[BridgeAR]

V8-CI https://ci.nodejs.org/job/node-test-commit-v8-linux/1691/
CI https://ci.nodejs.org/job/node-test-pull-request/17237/

[addaleax]

@hashseed Hope it’s okay to ask… Is it always okay to “just” add a HandleScope, or can V8 be in a state where that (or allocating handles in general) is not allowed?

[Trott]

Given the narrow scope of the change, would it make sense to fast track this to get CI back to green?

[Trott]

Fixes the test that's been failing, so I'm 👍. Since this is a change in deps/v8/src, do we have to do anything special to make sure the patch gets re-floated when we update? (I guess that question may be for @nodejs/v8-update.)

[addaleax]

@Trott As per the discussion in #22775, I don’t think we need to re-float this after updating to V8 7.0?

[hashseed]

@Trott no need to refloat. It has been fixed as a byproduct of a refactoring.

@addaleax creating handle scopes and handles only hurts if done in a loop, it could slow down performance. You can't create handles outside the main thread of course. Also a handle scopes also limits handles created inside it to that scope.

[Trott]

Resume build: https://ci.nodejs.org/job/node-test-pull-request/17258/

I think arm-fanned doesn't play well with Resume Build so that one may need a Rebuild... Anyway, all failures look unrelated to this change, of course (and mostly build/infra related).

[refack]

Resume 2: https://ci.nodejs.org/job/node-test-pull-request/17263/

[hashseed]

Landed in dafaa6e.

[addaleax]

Closing, since this has landed :)