test: remove flaky designation for test

[Trott]

Unreliability for test-trace-events-fs-sync is believed to have been
fixed. Remove flaky designation.

Ref: #22812
Ref: #21038 (comment)

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/887/pipeline

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/17182/

[Trott]

@ofrobots

[Trott]

Looks like we're now getting SIGABRT rather than SIGSEGV? Is that a step in the right direction? (I think so...)

https://ci.nodejs.org/job/node-test-commit-freebsd/20477/nodes=freebsd11-x64/console

22:24:54 not ok 1905 parallel/test-trace-events-fs-sync
22:24:54   ---
22:24:54   duration_ms: 3.60
22:24:54   severity: fail
22:24:54   exitcode: 1
22:24:54   stack: |-
22:24:54     assert.js:84
22:24:54       throw new AssertionError(obj);
22:24:54       ^
22:24:54     
22:24:54     AssertionError [ERR_ASSERTION]: fs.sync.stat:
22:24:54     { status: null,
22:24:54       signal: 'SIGABRT',
22:24:54       output: [ null, '', '' ],
22:24:54       pid: 99508,
22:24:54       stdout: '',
22:24:54       stderr: '' }
22:24:54         at Object.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/parallel/test-trace-events-fs-sync.js:139:10)
22:24:54         at Module._compile (internal/modules/cjs/loader.js:694:30)
22:24:54         at Object.Module._extensions..js (internal/modules/cjs/loader.js:705:10)
22:24:54         at Module.load (internal/modules/cjs/loader.js:604:32)
22:24:54         at tryModuleLoad (internal/modules/cjs/loader.js:543:12)
22:24:54         at Function.Module._load (internal/modules/cjs/loader.js:535:3)
22:24:54         at Function.Module.runMain (internal/modules/cjs/loader.js:747:12)
22:24:54         at startup (internal/bootstrap/node.js:270:19)
22:24:54         at bootstrapNodeJSCore (internal/bootstrap/node.js:801:3)
22:24:54   ...

[Trott]

merge conflict resolved

CI: https://ci.nodejs.org/job/node-test-pull-request/17664/

[thefourtheye]

Do we need a node-stress-single-test, just to be sure?

[refack]

Stress -j 8 parallel/test-t* X 500 X [freebsd11-x64, rhel72-s390x, win2016-1p-vs2017 ]
https://ci.nodejs.org/job/node-stress-single-test/2061/

[Trott]

Windows stress test failed while building:

09:26:10 c:\workspace\node-stress-single-test\nodes\win2016-1p-vs2017\deps\v8\src\heap\code-stats.cc : fatal error C1002: compiler is out of heap space in pass 2 [c:\workspace\node-stress-single-test\nodes\win2016-1p-vs2017\deps\v8\gypfiles\mksnapshot.vcxproj]
09:26:10 LINK : fatal error LNK1257: code generation failed [c:\workspace\node-stress-single-test\nodes\win2016-1p-vs2017\deps\v8\gypfiles\mksnapshot.vcxproj]

[ofrobots]

That seems like an infra issue - c++ compiler ran out of memory.

…

On Sat, Oct 6, 2018, 10:22 AM Rich Trott ***@***.***> wrote: Windows stress test failed while building: 09:26:10 c:\workspace\node-stress-single-test\nodes\win2016-1p-vs2017\deps\v8\src\heap\code-stats.cc : fatal error C1002: compiler is out of heap space in pass 2 [c:\workspace\node-stress-single-test\nodes\win2016-1p-vs2017\deps\v8\gypfiles\mksnapshot.vcxproj]09:26:10 LINK : fatal error LNK1257: code generation failed [c:\workspace\node-stress-single-test\nodes\win2016-1p-vs2017\deps\v8\gypfiles\mksnapshot.vcxproj] — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#22856 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAE0qWmfM49QYdSWtKJCdbt6UflaBsRMks5uiObFgaJpZM4WooHB> .

[Trott]

Trying Windows again, hoping it compiles this time...: https://ci.nodejs.org/job/node-stress-single-test/2062/

[Trott]

Windows stress test compile failed again. 😞

[Trott]

Windows stress test rebuild but this time on a few different Windows variants. Hopefully if one or two fail, one or two others will successfully build and we'll see how the tests go. https://ci.nodejs.org/job/node-stress-single-test/2063/

[refack]

That's an interesting thing to follow up on form a @nodejs/build perspective.

09:26:10 deps\v8\src\heap\code-stats.cc : fatal error C1002: compiler is out of heap space in pass 2
[deps\v8\gypfiles\mksnapshot.vcxproj]

on https://ci.nodejs.org/computer/test-azure_msft-win2016-x64-6/

[refack]

🔨

https://ci.nodejs.org/job/node-stress-single-test/2061/nodes=freebsd11-x64/testReport/junit/(root)/test419/parallel_test_trace_events_category_used/

assert.js:84
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected

+ ''
- 'false\n'
    at ChildProcess.procDisabled.once.common.mustCall (/usr/home/iojs/build/workspace/node-stress-single-test/nodes/freebsd11-x64/test/parallel/test-trace-events-category-used.js:52:10)

1 in 500 on freebsd11

---

not ok 178 parallel/test-tls-zero-clear-in
  ---
  duration_ms: 1.209
  severity: fail
  exitcode: 1
  stack: |-
    events.js:167
          throw er; // Unhandled 'error' event
          ^
    
    Error: read ECONNRESET
        at TLSWrap.onStreamRead (internal/stream_base_commons.js:111:27)
    Emitted 'error' event at:
        at emitErrorNT (internal/streams/destroy.js:82:8)
        at emitErrorAndCloseNT (internal/streams/destroy.js:50:3)
        at process._tickCallback (internal/process/next_tick.js:63:19)
  ...

On https://ci.nodejs.org/job/node-stress-single-test/2063/nodes=win10-vs2017/

[refack]

IMHO stress passed.

[Trott]

Landed in e5170d4