benchmark: chunky http client benchmark variation and server by rudi-cilibrasi · Pull Request #228 · nodejs/node

rudi-cilibrasi · 2015-01-01T22:03:31Z

No description provided.

bnoordhuis · 2015-01-06T16:03:03Z

benchmark/net/chunky_http_client.js

Style: please indent with two spaces here.

rudi-cilibrasi · 2015-01-07T04:35:23Z

Thanks for the great comments Ben they are all done!

trevnorris · 2015-01-16T00:22:01Z

benchmark/net/http_server_for_chunky_client.js

This could throw with Error: ENOENT. Instead do:

try { fs.unlinkSync(PIPE); } catch (e) { }

bnoordhuis · 2015-01-22T13:58:44Z

benchmark/net/chunky_http_client.js

Style: the convention is to use single quotes. There is usually a blank line after 'use strict'.

bnoordhuis · 2015-01-22T14:11:54Z

benchmark/net/http_server_for_chunky_client.js

If you're not going to handle them, you should let 'error' events bubble up.

rudi-cilibrasi · 2015-01-30T05:07:28Z

Hi Trevor and Ben, I think the style is all set! Please let me know if you spot anything else I appreciate the practice.

rudi-cilibrasi · 2015-02-13T18:08:26Z

ping @trevnorris curious on your thoughts

trevnorris · 2015-02-16T22:34:03Z

benchmark/net/chunky_http_client.js

Are you sure conf.len and conf.num will always be defined? If not they'll return NaN.

Yes, this seems to be the assumption in all of the configuration code in the benchmark client headers net/ section. I am simply following that pre-existing convention. I did notice that there is a conf.len downstairs line 65 or so. I pushed (rebase -i) a minor cleanup fix for it to use 'len' instead. But both seem fine and correct to me so I doubt that this is more than a very minor aesthetic clarity issue.

trevnorris · 2015-02-16T22:35:50Z

One minor comment, but don't see anything I oppose here.

brendanashworth · 2015-02-25T08:53:33Z

I'm gonna bump this up and jump in. Hows this going?

rudi-cilibrasi · 2015-02-25T09:55:46Z

Fine. I'm happy to have this patch accepted when applicable.

trevnorris · 2015-02-26T19:34:41Z

Seems you've addressed everything from Ben and myself. I'll LGTM. @bnoordhuis?

rudi-cilibrasi · 2015-03-06T01:20:11Z

ping @bnoordhuis it's been a couple weeks since anything has happened on this patch. may i ask if it is reasonable yet?

trevnorris · 2015-03-06T20:43:16Z

@rudi-cilibrasi i'll give until monday for any other responses. if non come ping me and i'll land this.

bnoordhuis · 2015-03-06T20:45:57Z

Sorry, the notification got lost in the gaping black hole that's my email backlog. I defer to @trevnorris; if he is happy with it, I'm happy with it. :-)

fnvhash · 2015-03-09T14:54:34Z

@trevnorris and @bnoordhuis

no problems over the weekend. seems to be ready for acceptance. :-)

On Fri, Mar 6, 2015 at 12:46 PM, Ben Noordhuis notifications@github.com
wrote:

Sorry, the notification got lost in the gaping black hole that's my email
backlog. I defer to @trevnorris https://github.com/trevnorris; if he is
happy with it, I'm happy with it. :-)

—
Reply to this email directly or view it on GitHub
#228 (comment).

Happy to Code with Integrity : Software Engineering Code of Ethics and
Professional Practice http://www.acm.org/about/about/se-code

PR-URL: #228 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

trevnorris · 2015-03-09T17:00:00Z

Thanks. Landed in 030a923.

@arcanis

Full release notes: A few meaty bugfixes, and introducing `peerDependenciesMeta`. FEATURES * [`a12341088`](npm/cli@a123410) [nodejs#224](npm/cli#224) Implements peerDependenciesMeta ([@arcanis](https://github.com/arcanis)) * [`2f3b79bba`](npm/cli@2f3b79b) [nodejs#234](npm/cli#234) add new forbidden 403 error code ([@claudiahdz](https://github.com/claudiahdz)) BUGFIXES * [`24acc9fc8`](npm/cli@24acc9f) and [`45772af0d`](npm/cli@45772af) [nodejs#217](npm/cli#217) [npm.community#8863](https://npm.community/t/installing-the-same-module-under-multiple-relative-paths-fails-on-linux/8863) [npm.community#9327](https://npm.community/t/reinstall-breaks-after-npm-update-to-6-10-2/9327,) do not descend into directory deps' child modules, fix shrinkwrap files that inappropriately list child nodes of symlink packages ([@isaacs](https://github.com/isaacs) and [@salomvary](https://github.com/salomvary)) * [`50cfe113d`](npm/cli@50cfe11) [nodejs#229](npm/cli#229) fixed typo in semver doc ([@gall0ws](https://github.com/gall0ws)) * [`e8fb2a1bd`](npm/cli@e8fb2a1) [nodejs#231](npm/cli#231) Fix spelling mistakes in CHANGELOG-3.md ([@XhmikosR](https://github.com/XhmikosR)) * [`769d2e057`](npm/cli@769d2e0) [npm/uid-number#7](npm/uid-number#7) Better error on invalid `--user`/`--group` configs. This addresses the issue when people fail to install binary packages on Docker and other environments where there is no 'nobody' user. ([@isaacs](https://github.com/isaacs)) * [`8b43c9624`](npm/cli@8b43c96) [nodejs#28987](nodejs#28987) [npm.community#6032](https://npm.community/t/npm-ci-doesnt-respect-npmrc-variables/6032) [npm.community#6658](https://npm.community/t/npm-ci-doesnt-fill-anymore-the-process-env-npm-config-cache-variable-on-post-install-scripts/6658) [npm.community#6069](https://npm.community/t/npm-ci-does-not-compile-native-dependencies-according-to-npmrc-configuration/6069) [npm.community#9323](https://npm.community/t/npm-6-9-x-not-passing-environment-to-node-gyp-regression-from-6-4-x/9323/2) Fix the regression where random config values in a .npmrc file are not passed to lifecycle scripts, breaking build processes which rely on them. ([@isaacs](https://github.com/isaacs)) * [`8b85eaa47`](npm/cli@8b85eaa) save files with inferred ownership rather than relying on `SUDO_UID` and `SUDO_GID`. ([@isaacs](https://github.com/isaacs)) * [`b7f6e5f02`](npm/cli@b7f6e5f) Infer ownership of shrinkwrap files ([@isaacs](https://github.com/isaacs)) * [`54b095d77`](npm/cli@54b095d) [nodejs#235](npm/cli#235) Add spec to dist-tag remove function ([@theberbie](https://github.com/theberbie)) DEPENDENCIES * [`dc8f9e52f`](npm/cli@dc8f9e5) `pacote@9.5.7`: Infer the ownership of all unpacked files in `node_modules`, so that we never have user-owned files in root-owned folders, or root-owned files in user-owned folders. ([@isaacs](https://github.com/isaacs)) * [`bb33940c3`](npm/cli@bb33940) `cmd-shim@3.0.0`: * [`9c93ac3`](npm/cmd-shim@9c93ac3) [#2](npm/cmd-shim#2) [npm#3380](npm/npm#3380) Handle environment variables properly ([@basbossink](https://github.com/basbossink)) * [`2d277f8`](npm/cmd-shim@2d277f8) [nodejs#25](npm/cmd-shim#25) [nodejs#36](npm/cmd-shim#36) [nodejs#35](npm/cmd-shim#35) Fix 'no shebang' case by always providing `$basedir` in shell script ([@igorklopov](https://github.com/igorklopov)) * [`adaf20b`](npm/cmd-shim@adaf20b) [nodejs#26](npm/cmd-shim#26) Fix `$*` causing an error when arguments contain parentheses ([@satazor](https://github.com/satazor)) * [`49f0c13`](npm/cmd-shim@49f0c13) [nodejs#30](npm/cmd-shim#30) Fix paths for MSYS/MINGW bash ([@dscho](https://github.com/dscho)) * [`51a8af3`](npm/cmd-shim@51a8af3) [nodejs#34](npm/cmd-shim#34) Add proper support for PowerShell ([@ExE-Boss](https://github.com/ExE-Boss)) * [`4c37e04`](npm/cmd-shim@4c37e04) [#10](npm/cmd-shim#10) Work around quoted batch file names ([@isaacs](https://github.com/isaacs)) * [`a4e279544`](npm/cli@a4e2795) `npm-lifecycle@3.1.3` ([@isaacs](https://github.com/isaacs)): * fail properly if `uid-number` raises an error * [`7086a1809`](npm/cli@7086a18) `libcipm@4.0.3` ([@isaacs](https://github.com/isaacs)) * [`8845141f9`](npm/cli@8845141) `read-package-json@2.1.0` ([@isaacs](https://github.com/isaacs)) * [`51c028215`](npm/cli@51c0282) `bin-links@1.1.3` ([@isaacs](https://github.com/isaacs)) * [`534a5548c`](npm/cli@534a554) `read-cmd-shim@1.0.3` ([@isaacs](https://github.com/isaacs)) * [`3038f2fd5`](npm/cli@3038f2f) `gentle-fs@2.2.1` ([@isaacs](https://github.com/isaacs)) * [`a609a1648`](npm/cli@a609a16) `graceful-fs@4.2.2` ([@isaacs](https://github.com/isaacs)) * [`f0346f754`](npm/cli@f0346f7) `cacache@12.0.3` ([@isaacs](https://github.com/isaacs)) * [`ca9c615c8`](npm/cli@ca9c615) `npm-pick-manifest@3.0.0` ([@isaacs](https://github.com/isaacs)) * [`b417affbf`](npm/cli@b417aff) `pacote@9.5.8` ([@isaacs](https://github.com/isaacs)) TESTS * [`b6df0913c`](npm/cli@b6df091) [nodejs#228](npm/cli#228) Proper handing of /usr/bin/node lifecycle-path test ([@olivr70](https://github.com/olivr70)) * [`aaf98e88c`](npm/cli@aaf98e8) `npm-registry-mock@1.3.0` ([@isaacs](https://github.com/isaacs))

@isaacs

Full changelog: 6.11.1 (2019-08-20): Fix a regression for windows command shim syntax. * [`37db29647`](npm/cli@37db296) `cmd-shim@3.0.2` ([@isaacs](https://github.com/isaacs)) v6.11.0 (2019-08-20): A few meaty bugfixes, and introducing `peerDependenciesMeta`. FEATURES * [`a12341088`](npm/cli@a123410) [nodejs#224](npm/cli#224) Implements peerDependenciesMeta ([@arcanis](https://github.com/arcanis)) * [`2f3b79bba`](npm/cli@2f3b79b) [nodejs#234](npm/cli#234) add new forbidden 403 error code ([@claudiahdz](https://github.com/claudiahdz)) BUGFIXES * [`24acc9fc8`](npm/cli@24acc9f) and [`45772af0d`](npm/cli@45772af) [nodejs#217](npm/cli#217) [npm.community#8863](https://npm.community/t/installing-the-same-module-under-multiple-relative-paths-fails-on-linux/8863) [npm.community#9327](https://npm.community/t/reinstall-breaks-after-npm-update-to-6-10-2/9327,) do not descend into directory deps' child modules, fix shrinkwrap files that inappropriately list child nodes of symlink packages ([@isaacs](https://github.com/isaacs) and [@salomvary](https://github.com/salomvary)) * [`50cfe113d`](npm/cli@50cfe11) [nodejs#229](npm/cli#229) fixed typo in semver doc ([@gall0ws](https://github.com/gall0ws)) * [`e8fb2a1bd`](npm/cli@e8fb2a1) [nodejs#231](npm/cli#231) Fix spelling mistakes in CHANGELOG-3.md ([@XhmikosR](https://github.com/XhmikosR)) * [`769d2e057`](npm/cli@769d2e0) [npm/uid-number#7](npm/uid-number#7) Better error on invalid `--user`/`--group` configs. This addresses the issue when people fail to install binary packages on Docker and other environments where there is no 'nobody' user. ([@isaacs](https://github.com/isaacs)) * [`8b43c9624`](npm/cli@8b43c96) [nodejs#28987](nodejs#28987) [npm.community#6032](https://npm.community/t/npm-ci-doesnt-respect-npmrc-variables/6032) [npm.community#6658](https://npm.community/t/npm-ci-doesnt-fill-anymore-the-process-env-npm-config-cache-variable-on-post-install-scripts/6658) [npm.community#6069](https://npm.community/t/npm-ci-does-not-compile-native-dependencies-according-to-npmrc-configuration/6069) [npm.community#9323](https://npm.community/t/npm-6-9-x-not-passing-environment-to-node-gyp-regression-from-6-4-x/9323/2) Fix the regression where random config values in a .npmrc file are not passed to lifecycle scripts, breaking build processes which rely on them. ([@isaacs](https://github.com/isaacs)) * [`8b85eaa47`](npm/cli@8b85eaa) save files with inferred ownership rather than relying on `SUDO_UID` and `SUDO_GID`. ([@isaacs](https://github.com/isaacs)) * [`b7f6e5f02`](npm/cli@b7f6e5f) Infer ownership of shrinkwrap files ([@isaacs](https://github.com/isaacs)) * [`54b095d77`](npm/cli@54b095d) [nodejs#235](npm/cli#235) Add spec to dist-tag remove function ([@theberbie](https://github.com/theberbie)) DEPENDENCIES * [`dc8f9e52f`](npm/cli@dc8f9e5) `pacote@9.5.7`: Infer the ownership of all unpacked files in `node_modules`, so that we never have user-owned files in root-owned folders, or root-owned files in user-owned folders. ([@isaacs](https://github.com/isaacs)) * [`bb33940c3`](npm/cli@bb33940) `cmd-shim@3.0.0`: * [`9c93ac3`](npm/cmd-shim@9c93ac3) [#2](npm/cmd-shim#2) [npm#3380](npm/npm#3380) Handle environment variables properly ([@basbossink](https://github.com/basbossink)) * [`2d277f8`](npm/cmd-shim@2d277f8) [nodejs#25](npm/cmd-shim#25) [nodejs#36](npm/cmd-shim#36) [nodejs#35](npm/cmd-shim#35) Fix 'no shebang' case by always providing `$basedir` in shell script ([@igorklopov](https://github.com/igorklopov)) * [`adaf20b`](npm/cmd-shim@adaf20b) [nodejs#26](npm/cmd-shim#26) Fix `$*` causing an error when arguments contain parentheses ([@satazor](https://github.com/satazor)) * [`49f0c13`](npm/cmd-shim@49f0c13) [nodejs#30](npm/cmd-shim#30) Fix paths for MSYS/MINGW bash ([@dscho](https://github.com/dscho)) * [`51a8af3`](npm/cmd-shim@51a8af3) [nodejs#34](npm/cmd-shim#34) Add proper support for PowerShell ([@ExE-Boss](https://github.com/ExE-Boss)) * [`4c37e04`](npm/cmd-shim@4c37e04) [#10](npm/cmd-shim#10) Work around quoted batch file names ([@isaacs](https://github.com/isaacs)) * [`a4e279544`](npm/cli@a4e2795) `npm-lifecycle@3.1.3` ([@isaacs](https://github.com/isaacs)): * fail properly if `uid-number` raises an error * [`7086a1809`](npm/cli@7086a18) `libcipm@4.0.3` ([@isaacs](https://github.com/isaacs)) * [`8845141f9`](npm/cli@8845141) `read-package-json@2.1.0` ([@isaacs](https://github.com/isaacs)) * [`51c028215`](npm/cli@51c0282) `bin-links@1.1.3` ([@isaacs](https://github.com/isaacs)) * [`534a5548c`](npm/cli@534a554) `read-cmd-shim@1.0.3` ([@isaacs](https://github.com/isaacs)) * [`3038f2fd5`](npm/cli@3038f2f) `gentle-fs@2.2.1` ([@isaacs](https://github.com/isaacs)) * [`a609a1648`](npm/cli@a609a16) `graceful-fs@4.2.2` ([@isaacs](https://github.com/isaacs)) * [`f0346f754`](npm/cli@f0346f7) `cacache@12.0.3` ([@isaacs](https://github.com/isaacs)) * [`ca9c615c8`](npm/cli@ca9c615) `npm-pick-manifest@3.0.0` ([@isaacs](https://github.com/isaacs)) * [`b417affbf`](npm/cli@b417aff) `pacote@9.5.8` ([@isaacs](https://github.com/isaacs)) TESTS * [`b6df0913c`](npm/cli@b6df091) [nodejs#228](npm/cli#228) Proper handing of /usr/bin/node lifecycle-path test ([@olivr70](https://github.com/olivr70)) * [`aaf98e88c`](npm/cli@aaf98e8) `npm-registry-mock@1.3.0` ([@isaacs](https://github.com/isaacs))

bnoordhuis reviewed Jan 6, 2015
View reviewed changes

benchmark/net/chunky_http_client.js Outdated

Copy link

Member

bnoordhuis Jan 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style: please indent with two spaces here.

benchmark: chunky http client benchmark variation and server

85df665

trevnorris reviewed Jan 16, 2015
View reviewed changes

benchmark: few minor output improvements and exception handling

24d23d3

bnoordhuis reviewed Jan 22, 2015
View reviewed changes

benchmark/net/http_server_for_chunky_client.js Outdated

Copy link

Member

bnoordhuis Jan 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're not going to handle them, you should let 'error' events bubble up.

trevnorris self-assigned this Jan 30, 2015

rudi-cilibrasi mentioned this pull request Feb 13, 2015

Improve allocation speed and reduce memory copying to increase HTTP pars... #199

Closed

trevnorris reviewed Feb 16, 2015
View reviewed changes

benchmark: more formatting improvements and simplification

74246a0

trevnorris pushed a commit that referenced this pull request Mar 9, 2015

benchmark: chunky http client benchmark variation

030a923

PR-URL: #228 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

trevnorris closed this Mar 9, 2015

rvagg mentioned this pull request Mar 9, 2015

Release proposal: v1.5.1 #1096

Closed

snyk-bot mentioned this pull request Feb 12, 2022

[Snyk] Upgrade eslint-plugin-promise from 5.2.0 to 6.0.0 Iceymann18777/node#11

Open

jesec mentioned this pull request Jul 4, 2023

RFC: pkg 6.0 vercel/pkg#1655

Closed

Uh oh!

Conversation

rudi-cilibrasi commented Jan 1, 2015

Uh oh!

bnoordhuis Jan 6, 2015

Choose a reason for hiding this comment

Uh oh!

rudi-cilibrasi commented Jan 7, 2015

Uh oh!

trevnorris Jan 16, 2015

Choose a reason for hiding this comment

Uh oh!

bnoordhuis Jan 22, 2015

Choose a reason for hiding this comment

Uh oh!

bnoordhuis Jan 22, 2015

Choose a reason for hiding this comment

Uh oh!

rudi-cilibrasi commented Jan 30, 2015

Uh oh!

rudi-cilibrasi commented Feb 13, 2015

Uh oh!

trevnorris Feb 16, 2015

Choose a reason for hiding this comment

Uh oh!

rudi-cilibrasi Feb 17, 2015

Choose a reason for hiding this comment

Uh oh!

trevnorris commented Feb 16, 2015

Uh oh!

brendanashworth commented Feb 25, 2015

Uh oh!

rudi-cilibrasi commented Feb 25, 2015

Uh oh!

trevnorris commented Feb 26, 2015

Uh oh!

rudi-cilibrasi commented Mar 6, 2015

Uh oh!

trevnorris commented Mar 6, 2015

Uh oh!

bnoordhuis commented Mar 6, 2015

Uh oh!

fnvhash commented Mar 9, 2015

Uh oh!

trevnorris commented Mar 9, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants