crypto: rename symbols to match guidelines#22770
Closed
tniessen wants to merge 1 commit intonodejs:masterfrom
Closed
crypto: rename symbols to match guidelines#22770tniessen wants to merge 1 commit intonodejs:masterfrom
tniessen wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
crypto
addaleax
approved these changes
Sep 9, 2018
targos
approved these changes
Sep 9, 2018
lpinca
approved these changes
Sep 9, 2018
BridgeAR
approved these changes
Sep 10, 2018
cjihrig
approved these changes
Sep 10, 2018
jasnell
approved these changes
Sep 10, 2018
Member
Author
|
Thanks @danbev for starting CI: https://ci.nodejs.org/job/node-test-pull-request/17127/ |
Member
Author
|
CI was stopped, rebuilding everything... https://ci.nodejs.org/job/node-test-pull-request/17141/ |
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Sep 12, 2018
PR-URL: nodejs#22770 Refs: nodejs#22684 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
Author
|
CI is yellow, GH is still not updating. Landed in 79d2536. |
targos
pushed a commit
that referenced
this pull request
Sep 14, 2018
PR-URL: #22770 Refs: #22684 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 19, 2018
PR-URL: #22770 Refs: #22684 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 20, 2018
PR-URL: #22770 Refs: #22684 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested by @addaleax in #22684, rename symbols to match the variable name.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes