tools,doc: apilinks should handle root scenarios

[kfarnung]

• Prevent crash when setting root properties
• Allow return outside of function

In Node-ChakraCore we ran into some issues with this script. Rather than fix them downstream I think the fixes are potentially valuable here.

Root properties example: https://github.com/nodejs/node-chakracore/blob/a3d02b2794fa7fdf03be48d3b4a8cd87b7345402/lib/trace_mgr.js#L618

Return outside of function example: https://github.com/nodejs/node-chakracore/blob/a3d02b2794fa7fdf03be48d3b4a8cd87b7345402/lib/v8.js#L17-L19

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[nodejs-github-bot]

@kfarnung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/810/pipeline

[rubys]

Nit: should probably be lhs.type (and yes, that applies to the line below too).

[kfarnung]

Thanks! While doing this I noticed the redundant check and removed it. The logic should be that we only look for the object in cases where it's already a MemberExpression and only replace it in cases where the object is also MemberExpression. I compared the output with and without my changes and it's identical, so I think this logic is sound.

[kfarnung]

Restarted the lite build: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/812/pipeline

[kfarnung]

Another lite re-run: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/819/pipeline

[addaleax]

Thanks!

[kfarnung]

CI: https://ci.nodejs.org/job/node-test-pull-request/17077/

[kfarnung]

Looks like #22706 should replace part of my fix, I've rebased and I'm retesting locally before pushing.

[kfarnung]

Rebased and passing tests.

[kfarnung]

CI re-run: https://ci.nodejs.org/job/node-test-pull-request/17096/

[kfarnung]

Landed in 3bdc61d