src: disable debug options when inspector is unavailable#22657
Closed
addaleax wants to merge 3 commits intonodejs:masterfrom
Closed
src: disable debug options when inspector is unavailable#22657addaleax wants to merge 3 commits intonodejs:masterfrom
addaleax wants to merge 3 commits intonodejs:masterfrom
Conversation
This fixes `parallel/test-cli-node-print-help` when Node.js is compiled without the inspector.
nodejs-github-bot
added
the
c++
Member
Author
|
@nodejs/build I don’t understand why e.g. https://ci.nodejs.org/job/node-test-commit-linux-containered/6764/nodes=ubuntu1604_sharedlibs_withoutintl_x64/console is not marked as a failure? |
addaleax
added
inspector
gireeshpunathil
approved these changes
Sep 2, 2018
Member
Author
|
CI: https://ci.nodejs.org/job/node-test-pull-request/16961/ (:heavy_check_mark:) |
addaleax
added
the
author ready
targos
approved these changes
Sep 2, 2018
Trott
reviewed
Sep 2, 2018
| 'use strict'; | ||
| require('../common'); | ||
| const common = require('../common'); | ||
| common.skipIfInspectorDisabled(); |
Member
There was a problem hiding this comment.
Nit: Instead of skipping the test, can we use it to guard just the arguments that require inspector? We should still be able to run this on --eval, no?
Member
Author
There was a problem hiding this comment.
I think so, yes. Done! :)
Trott
approved these changes
Sep 2, 2018
3 tasks
Contributor
|
Please 👍 for fast tracking this regression fix. |
refack
approved these changes
Sep 2, 2018
Contributor
|
CI with fixed configuration: https://ci.nodejs.org/job/node-test-commit-linux-containered/6807/ |
lundibundi
approved these changes
Sep 2, 2018
Member
Author
|
Landed in c100d40 – thanks for the reviews! |
addaleax
added a commit
that referenced
this pull request
Sep 2, 2018
This fixes `parallel/test-cli-node-print-help` when Node.js is compiled without the inspector. PR-URL: #22657 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
This fixes `parallel/test-cli-node-print-help` when Node.js is compiled without the inspector. PR-URL: #22657 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
This fixes `parallel/test-cli-node-print-help` when Node.js is compiled without the inspector. PR-URL: #22657 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes
parallel/test-cli-node-print-helpwhen Node.js is compiled without the inspector.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes